Closed
Bug 1279930
Opened 8 years ago
Closed 8 years ago
Stop using gfxContext device offsets on the temporary gfxContext in the GTK code's nsWindow::OnExposeEvent
Categories
(Core :: Widget: Gtk, defect)
Core
Widget: Gtk
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(1 file)
|
(deleted),
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
DrawTargets don't support device offsets. As part of the move to Moz2D we should stop using gfxContext device offsets on the temporary gfxContext in the GTK code's nsWindow::OnExposeEvent.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8762559 -
Flags: review?(mstange)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8762559 [details] [diff] [review]
patch
Review of attachment 8762559 [details] [diff] [review]:
-----------------------------------------------------------------
::: widget/gtk/nsWindow.cpp
@@ +2281,4 @@
> } else {
> gfxUtils::ClipToRegion(dt, region.ToUnknownRegion());
>
> + dt->SetTransform(Matrix::Translation(-offset);
I think this line is unnecessary. It's already executed above. (And in the case where it's not executed, it'll make no difference because offset will be 0,0.)
Attachment #8762559 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Well spotted.
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/127e74cb33c3
Stop using gfxContext device offsets on the temporary gfxContext in the GTK code's nsWindow::OnExposeEvent. r=mstange
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•