Closed
Bug 1280064
Opened 8 years ago
Closed 8 years ago
Do not use PRLock in GCRuntime and PRCondVar in GCHelperState
Categories
(Core :: JavaScript Engine, defect, P1)
Core
JavaScript Engine
Tracking
()
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8762694 -
Flags: review?(terrence)
Assignee | ||
Comment 2•8 years ago
|
||
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•8 years ago
|
||
Unbreak non-DEBUG builds.
Attachment #8762705 -
Flags: review?(terrence)
Assignee | ||
Updated•8 years ago
|
Attachment #8762694 -
Attachment is obsolete: true
Attachment #8762694 -
Flags: review?(terrence)
Assignee | ||
Comment 4•8 years ago
|
||
Updated•8 years ago
|
Comment 5•8 years ago
|
||
Comment on attachment 8762705 [details] [diff] [review]
Do not use PRLock in GCRuntime and PRCondVar in GCHelperState
Review of attachment 8762705 [details] [diff] [review]:
-----------------------------------------------------------------
Excellent! Sorry for the late reviews on these. For some reason, bugzilla did not let me log in all last week, despite using what I've now verified was the right password.
::: js/src/jsgc.cpp
@@ +884,5 @@
> inUnsafeRegion(0),
> noGCOrAllocationCheck(0),
> noNurseryAllocationCheck(0),
> #endif
> + lock(),
You should be able to just remove this line entirely, right?
::: js/src/jsgc.h
@@ +18,5 @@
>
> #include "js/GCAPI.h"
> #include "js/SliceBudget.h"
> #include "js/Vector.h"
>
Remove this line-break while you are here, please.
Attachment #8762705 -
Flags: review?(terrence) → review+
Updated•8 years ago
|
Iteration: 50.1 → 50.2
Updated•8 years ago
|
Whiteboard: [devtools-html]
Pushed by nfitzgerald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c36f5c0bed2c
Do not use PRLock in GCRuntime and PRCondVar in GCHelperState; r=terrence
Pushed by nfitzgerald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b46f11f21ce3
Address review nits; r=terrence
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c36f5c0bed2c
https://hg.mozilla.org/mozilla-central/rev/b46f11f21ce3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Updated•8 years ago
|
Whiteboard: [devtools-html]
You need to log in
before you can comment on or make changes to this bug.
Description
•