In https://bugzilla.mozilla.org/show_bug.cgi?id=1276412 we added an access key z for the Context Menu -> Open Link In New Container Tab option. We need to find a better access key if we can, hopefully a letter that is in the string. Also, in browser_contextmenu.js, we had to add a blank line to account for the submenu: // We need a blank entry here because the conatiners submenu is // dynamically generated with no ids. ...(hasContainers ? ["", null] : []), We should try and see if we can find a more elegant solution.

Added a patch to change the new tab containers menu to be the same as the file menu 'b' accesskey. I'm not sure if we can improve that other test, however this is how the pocket menu is working in the test so not sure of the issue? Perhaps this should be a follow up anyway?

Comment on attachment 8814207 [details] Bug 1280253 - Change 'Open Link in New Container Tab' access key to match menu 'b' https://reviewboard.mozilla.org/r/95468/#review97190

Comment on attachment 8814207 [details] Bug 1280253 - Change 'Open Link in New Container Tab' access key to match menu 'b' Do you see any conflict having this shortcut?

Comment on attachment 8814207 [details] Bug 1280253 - Change 'Open Link in New Container Tab' access key to match menu 'b' https://reviewboard.mozilla.org/r/95468/#review97194 I can't spot any item with a 'b' as accesskey, besides tab context commands.

(In reply to Jonathan Kingston [:jkt] from comment #2) > Added a patch to change the new tab containers menu to be the same as the > file menu 'b' accesskey. > > I'm not sure if we can improve that other test, however this is how the > pocket menu is working in the test so not sure of the issue? Perhaps this > should be a follow up anyway? File a followup for it.

(In reply to Tanvi Vyas [:tanvi] from comment #6) > (In reply to Jonathan Kingston [:jkt] from comment #2) > > Added a patch to change the new tab containers menu to be the same as the > > file menu 'b' accesskey. > > > > I'm not sure if we can improve that other test, however this is how the > > pocket menu is working in the test so not sure of the issue? Perhaps this > > should be a follow up anyway? > > File a followup for it. Nevermind, since other tests follow this convention to, lets just leave it.

there seems to be issues in mozreview that the reviewers need to fix first before we can use autoland :Unable to update reviewers as the review request has pending changes (the patch author has a draft)"

That's weird, I see 'Approved For Landing - You have at least one valid ship it!', nor I see any request for changes in the history.

For some reason it has a draft, I canceled it.

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/0976b84eac9d Change 'Open Link in New Container Tab' access key to match menu 'b' r=baku,flod