The homeURL and workURL values are incorrectly swapped in the Address Book (both in the main display when a single card is chosen, as well as in the Card display when showing all attributes for an entry).

Here is a patch for 'ya... simple XUL/JS changes.

Sigh... only one problem with that patch; it transposes any existing cards (which is wrong.)

Better patch that changes the LDAP property mapping (so only LDAP-fetched cards are tweaked) so that existing Personal Addressbook cards remain correct.

This looks fine to me, but I'd like Seth or John to verify that this is the right thing.

Additionally, we may need to change the other two redundant tables where this info is kept.

Dan, yes Robert's patch looks good. I have updated the patch to include the other two cases I presume you are talking about. The other area where is this is used is in Outlook but it is correct there.

taking a look... rjc's initial patch makes sense, but I need to see if john's additions to the patch are also correct. I want to double check and make sure all these changes are correct.

1. Import Outlook AB: I can see the problem 2. Import Outlook Express AB: ok. So is this fix specific for importing from an Outlook Address Book?

This bug is related to LDAP only. My comment about Outlook related to the dynamic integration of Outlook and Outlook Express in Mozilla (bug #78931 and bug #83103) as opposed to the Importing of Outlook and Outlook Express. Yes, I also believe we have a problem in Importing from Outlook. It appears that we map the PR_BUSINESS_HOME_PAGE (confusing name!) to Mozilla's Home Web Page rather than the Business Web Page. But because Outlook uses only one web page field, then this may explain why this is not such a big issue. In contrast Outlook Express supports both a Home Web Page and a Business Web Page. It appears following bug #93588 that this is now fixed. So to be accurate we could create a new bug for the Import of Outlook.

dmose wrote: "Additionally, we may need to change the other two redundant tables where this info is kept." dan's guess is right, export and import have issues. it looks like john's last patch addresses some of these, but not all. I'll attach another patch.

This latest patch looks good. r=john.marmion

Comment on attachment 73177 [details] [diff] [review] updated patch sr=bienvenu

Comment on attachment 73177 [details] [diff] [review] updated patch r=bhuvan

Comment on attachment 73177 [details] [diff] [review] updated patch a=asa (on behalf of drivers) for checkin to the 1.0 trunk

fixed thanks to rjc for the bug and the initial patch, and to john for the follow up patches and the review.

Setting qa contact to Yulian.

fyi: logged bug# 134014 to track the import from outlook problem where the web pages are not mapped correctly (as stated in comment# 9).

Robert, Would you confirm the fix with your Directory Server (at home?) which uses the attributes: "homeURL" and "workURL" ? Thanks!

Confirmed.

Verified by reporter