Closed
Bug 1280388
Opened 8 years ago
Closed 8 years ago
[a11y] Make the bug summary a heading level 1
Categories
(bugzilla.mozilla.org :: User Interface, enhancement, P1)
Tracking
()
VERIFIED
FIXED
People
(Reporter: MarcoZ, Assigned: kohei)
References
Details
(Keywords: access)
Attachments
(1 file)
|
(deleted),
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
For screen reader users to more easily find it, the div with ID field-value-short_desc should be turned into an <h1> element. Or, if that is for some reason not really feasible, atleast give the div a role of "heading" and an aria-level of "1".
Having this div turned into an h1 will probably also help with indexing by search engines.
|
||
Updated•8 years ago
|
Severity: normal → enhancement
Priority: -- → P1
|
||
Comment 1•8 years ago
|
||
We would like to fix this before we switch over to modal as default.
Blocks: 1150541
|
Assignee | |
Comment 2•8 years ago
|
||
This one is pretty easy. Patch attached.
Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
|
|
||
Updated•8 years ago
|
Attachment #8825140 -
Flags: review?(dkl)
|
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8825140 [details] [diff] [review]
1280388.patch
Review of attachment 8825140 [details] [diff] [review]:
-----------------------------------------------------------------
r=dkl
Attachment #8825140 -
Flags: review?(dkl) → review+
|
|
||
Comment 4•8 years ago
|
||
To https://github.com/mozilla-bteam/bmo.git
8e1d385..ccb3104 master -> master
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•8 years ago
|
||
This change is live now.
|
Reporter | |
Comment 6•8 years ago
|
||
(In reply to David Lawrence [:dkl] from comment #5)
> This change is live now.
...and works great. :-)
Status: RESOLVED → VERIFIED
|
||
Updated•5 years ago
|
Component: User Interface: Modal → User Interface
You need to log in
before you can comment on or make changes to this bug.
Description
•