Closed
Bug 1280445
Opened 8 years ago
Closed 8 years ago
MediaStreamGraph holding on to Images until after gfx shutdown
Categories
(Core :: Audio/Video: MediaStreamGraph, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: pehrsons, Assigned: pehrsons)
References
Details
Attachments
(4 files)
This will be the short term fix of clearing out all Images during CC Unlink.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → pehrson
Status: NEW → ASSIGNED
Rank: 15
Priority: -- → P1
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/59424/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59424/
Attachment #8763090 -
Flags: review?(rjesup)
Attachment #8763091 -
Flags: review?(rjesup)
Attachment #8763092 -
Flags: review?(pehrson)
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/59426/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59426/
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/59428/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59428/
Assignee | ||
Updated•8 years ago
|
Attachment #8763092 -
Flags: review?(pehrson) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8763092 [details]
Bug 1280445 - Don't hold on to Image in MediaEngineDefaultVideoSource after Stop().
https://reviewboard.mozilla.org/r/59428/#review56492
Assignee | ||
Comment 5•8 years ago
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8763091 [details]
Bug 1280445 - Clear out all MediaSegments directly on forced MediaStreamGraph shutdown.
https://reviewboard.mozilla.org/r/59426/#review56500
Attachment #8763091 -
Flags: review?(rjesup) → review+
Comment 7•8 years ago
|
||
Comment on attachment 8763090 [details]
Bug 1280445 - Remove wrapper from MediaStream.
https://reviewboard.mozilla.org/r/59424/#review56502
Attachment #8763090 -
Flags: review?(rjesup) → review+
Assignee | ||
Comment 8•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/61264/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61264/
Attachment #8766287 -
Flags: review?(padenot)
Attachment #8763090 -
Flags: review?(padenot)
Assignee | ||
Comment 9•8 years ago
|
||
Comment on attachment 8763090 [details]
Bug 1280445 - Remove wrapper from MediaStream.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59424/diff/1-2/
Assignee | ||
Comment 10•8 years ago
|
||
Comment on attachment 8763091 [details]
Bug 1280445 - Clear out all MediaSegments directly on forced MediaStreamGraph shutdown.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59426/diff/1-2/
Assignee | ||
Comment 11•8 years ago
|
||
Comment on attachment 8763092 [details]
Bug 1280445 - Don't hold on to Image in MediaEngineDefaultVideoSource after Stop().
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59428/diff/1-2/
Assignee | ||
Comment 12•8 years ago
|
||
https://reviewboard.mozilla.org/r/59424/#review58132
padenot, could you just review the interdiff? Since jesup is on PTO.
I'm basically putting mConsumersToKeepAlive back (it was needed to not make bug 934512 worse) and cleaning up some.
Comment 13•8 years ago
|
||
Comment on attachment 8763090 [details]
Bug 1280445 - Remove wrapper from MediaStream.
https://reviewboard.mozilla.org/r/59424/#review58172
::: dom/media/DOMMediaStream.h:675
(Diff revision 2)
>
> // The interface through which we can query the stream producer for
> // track sources.
> RefPtr<MediaStreamTrackSourceGetter> mTrackSourceGetter;
>
> RefPtr<OwnedStreamListener> mOwnedListener;
Can we add a comment on those members ?
Attachment #8763090 -
Flags: review?(padenot) → review+
Updated•8 years ago
|
Attachment #8766287 -
Flags: review?(padenot) → review+
Comment 14•8 years ago
|
||
Comment on attachment 8766287 [details]
Bug 1280445 - Clean up MediaStreamAudioSourceNode's TrackListener on destruction.
https://reviewboard.mozilla.org/r/61264/#review58544
Comment 15•8 years ago
|
||
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2980e1dc86f2
Remove wrapper from MediaStream. r=jesup, r=padenot
https://hg.mozilla.org/integration/mozilla-inbound/rev/66dc5a74603a
Clear out all MediaSegments directly on forced MediaStreamGraph shutdown. r=jesup
https://hg.mozilla.org/integration/mozilla-inbound/rev/606dc72f3a62
Don't hold on to Image in MediaEngineDefaultVideoSource after Stop(). r=pehrsons
https://hg.mozilla.org/integration/mozilla-inbound/rev/5fa9c9c4260d
Clean up MediaStreamAudioSourceNode's TrackListener on destruction. r=padenot
Comment 16•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2980e1dc86f2
https://hg.mozilla.org/mozilla-central/rev/66dc5a74603a
https://hg.mozilla.org/mozilla-central/rev/606dc72f3a62
https://hg.mozilla.org/mozilla-central/rev/5fa9c9c4260d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•