Comment on attachment 8763351 [details] [diff] [review] unbreak mingw builds Thank you for the patch. To be landable, it'll need to be in the right format. It almost is, but the description needs to be of the format "Bug NNN - Description. r=reviewer". I'm forwarding the review to sfink, so with that in mind the description should be "Bug 1280789 - Unbreak mingw builds. r=sfink"

I didn't want to wait for the patch to be cleaned up, and it's simple enough, so I just landed it. Thanks for the patch! You've made quite a few patches now, so it would be nice if you could be generating them in the correct format (proper user in the patch, with unix line endings, and with appropriate commit messages for this project.) I wasn't sure whether to use zhoubcfan@163.com or c@lightme.us as the author, but I saw you have a bunch of patches landed with the first so I used that. Please submit things in a way that doesn't require landers to guess at your preferences.

Pushed by sfink@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2a807ca4df8e Unbreak mingw builds, r=sfink

Comment on attachment 8763351 [details] [diff] [review] unbreak mingw builds Oops, forgot to r+ this before landing!