Closed Bug 1280894 Opened 8 years ago Closed 7 years ago

[life] support ftl/l20n in diff mode

Categories

(Webtools Graveyard :: Elmo, defect)

Product:
Webtools Graveyard
Component:
Elmo
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Pike, Assigned: Pike)

References

Details

(Whiteboard: [gecko-l20n])

User Story

Diff support for ftl/l20n in elmo.

Attachments

(3 files)

bug 1280894, expose attributes on FluentEntity,
(deleted), text/x-review-board-request
stas
: review+
Details
bug 1280894, make AddRemove sort stable without map hacks,
(deleted), text/x-review-board-request
stas
: review+
Details
pull request for this and bug 1372257
(deleted), text/x-github-pull-request
Details
We need support for ftl in elmo to use our smart diffs for that. I'm not sure we need to support complex values for this.
Mass change dependency tree for bug 1279002 into a whiteboard keyword.
No longer blocks: gecko-l20n
Whiteboard: [gecko-l20n]
Thinking about this a bit: The easiest start here will be to treat messages as key-value, and switch on white-space: pre-wrap; for those, so that we get significant whitespace support. There are a few scenarios to support, I guess: - new and removed messages would work like now, might be good to test that still - We should have extra tests for internal changes to the structure -- add/remove/modify value -- add/remove/modify trait
Assignee: nobody → l10n
Gandalf said he'll work on this, assigning to him. Regarding comment 2, I think with the changes to the fluent syntax, we can create a diff line for value and a diff line per attribute. Looking at the code in apps/pushes/views/diff.py, it might make sense to update compare-locales in elmo first, in particular to pick up the changes from bug 1368444.
Assignee: l10n → gandalf
I filed bug 1372257 on the c-l update.
Turns out that it'll be easier for me to just grab this and do the corresponding jazz in compare-locales and elmo that I talked to stas about. We'll introduce a lazy EntityBase subclass for Attributes to compare with. Looking at the code it'll actually be easier to stick to compare-locales parser wrapper than trying to detect fluent explicitly before parsing.
Assignee: gandalf → l10n
Comment on attachment 8882128 [details] bug 1280894, expose attributes on FluentEntity, https://reviewboard.mozilla.org/r/153246/#review158422
Attachment #8882128 - Flags: review?(stas) → review+
Comment on attachment 8882129 [details] bug 1280894, make AddRemove sort stable without map hacks, https://reviewboard.mozilla.org/r/153248/#review158430
Attachment #8882129 - Flags: review?(stas) → review+
Attached file pull request for this and bug 1372257 (deleted) —
I'm moving this into one PR for both this and bug 1372257. Review is on stas, per conversation IRL.
Commit pushed to develop at https://github.com/mozilla/elmo https://github.com/mozilla/elmo/commit/e40c6b24ec5271dbfde8c6740c67747baaaa836c bug 1280894, add diff support for fluent, r=stas Also, update compare-locales once more to get better support from AddRemove
Landed. Will deploy as soon as we have a few other commits.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
This is deployed on both stage and prod now.
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: