Closed
Bug 1280949
Opened 8 years ago
Closed 8 years ago
Use regexpr to identify browser based directories for BrowserLoader
Categories
(DevTools :: Framework, defect, P1)
DevTools
Framework
Tracking
(firefox50 fixed)
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: Honza, Assigned: Honza)
References
Details
(Whiteboard: [devtools-html])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jlong
:
review+
|
Details | Diff | Splinter Review |
This is a follow up for bug 1259819
(see this comment: https://bugzilla.mozilla.org/show_bug.cgi?id=1259819#c12)
Browser loader is using hardcoded list of directories (BROWSER_BASED_DIRS) that is used to identify modules that should be loaded in browser environment. Since appending new directories into this list doesn't feel right we could introduce a regular expression that would be used to match the right directories.
Honza
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → odvarko
Assignee | ||
Comment 1•8 years ago
|
||
Here is a try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a3cd5ede0836
Honza
Attachment #8763590 -
Flags: review?(jlong)
Updated•8 years ago
|
Blocks: devtools-html-2
Status: NEW → ASSIGNED
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html]
Updated•8 years ago
|
Iteration: --- → 50.1
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8763590 [details] [diff] [review]
bug1280949.patch
Needs more testing yet.
Honza
Attachment #8763590 -
Flags: review?(jlong)
Assignee | ||
Comment 3•8 years ago
|
||
New version, let's see what the Try says:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e68c4e99ca5
Honza
Assignee | ||
Updated•8 years ago
|
Attachment #8763590 -
Attachment is obsolete: true
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8763605 [details] [diff] [review]
bug1280949.patch
There is one orange, but seems unrelated.
I think it's ready for review.
Honza
Attachment #8763605 -
Flags: review?(jlong)
Updated•8 years ago
|
Iteration: 50.1 → 50.2
Comment 5•8 years ago
|
||
Comment on attachment 8763605 [details] [diff] [review]
bug1280949.patch
Review of attachment 8763605 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, I can't think of any place where this would be a problem.
Attachment #8763605 -
Flags: review?(jlong) → review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/085b95afe6e3
Use regexpr to identify browser based directories. r=jlongster
Keywords: checkin-needed
Comment 8•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•