Closed Bug 1280949 Opened 8 years ago Closed 8 years ago

Use regexpr to identify browser based directories for BrowserLoader

Categories

(DevTools :: Framework, defect, P1)

defect

Tracking

(firefox50 fixed)

RESOLVED FIXED
Firefox 50
Iteration:
50.2 - Jul 4
Tracking Status
firefox50 --- fixed

People

(Reporter: Honza, Assigned: Honza)

References

Details

(Whiteboard: [devtools-html])

Attachments

(1 file, 1 obsolete file)

This is a follow up for bug 1259819 (see this comment: https://bugzilla.mozilla.org/show_bug.cgi?id=1259819#c12) Browser loader is using hardcoded list of directories (BROWSER_BASED_DIRS) that is used to identify modules that should be loaded in browser environment. Since appending new directories into this list doesn't feel right we could introduce a regular expression that would be used to match the right directories. Honza
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html]
Iteration: --- → 50.1
Comment on attachment 8763590 [details] [diff] [review] bug1280949.patch Needs more testing yet. Honza
Attachment #8763590 - Flags: review?(jlong)
Attachment #8763590 - Attachment is obsolete: true
Comment on attachment 8763605 [details] [diff] [review] bug1280949.patch There is one orange, but seems unrelated. I think it's ready for review. Honza
Attachment #8763605 - Flags: review?(jlong)
Iteration: 50.1 → 50.2
Comment on attachment 8763605 [details] [diff] [review] bug1280949.patch Review of attachment 8763605 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, I can't think of any place where this would be a problem.
Attachment #8763605 - Flags: review?(jlong) → review+
Great, thanks! Honza
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/085b95afe6e3 Use regexpr to identify browser based directories. r=jlongster
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: