Closed Bug 1281082 Opened 8 years ago Closed 8 years ago

move static_assert in NS_DECL_THREADSAFE_FFI_REFCOUNTING to the IMPL

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

patch
(deleted), patch
bholley
: review+
Details | Diff | Splinter Review
We don't use NS_DECL_THREADSAFE_FFI_REFCOUNTING yet, but if we do it'll probably fail to compile since the static_assert looks at a member on the target class (which ServoBindings.h won't #include). Let's move the static_assert to the NS_IMPL_THREADSAFE_FFI_REFCOUNTING.
Attached patch patch (deleted) — — Splinter Review
Attachment #8763725 - Flags: review?(bobbyholley)
Attachment #8763725 - Flags: review?(bobbyholley) → review+
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/452bee781482 Move static_assert in NS_DECL_THREADSAFE_FFI_REFCOUNTING to the IMPL. r=bholley
https://hg.mozilla.org/mozilla-central/rev/452bee781482
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: