Closed Bug 1281297 Opened 8 years ago Closed 7 years ago

iframe in shadow dom cannot be focused

Categories

(Core :: DOM: Core & HTML, defect, P2)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1430020

People

(Reporter: bdahl, Unassigned)

References

Details

Attachments

(1 file)

Attached file custom_element_focus.html (deleted) —
STR: 1) Enable webcomponents 2) Open attached test case 3) click within iframe 4) try to scroll with arrow keys Expected: The iframe is focused and the page scrolls Actual: The iframe doesn't scroll Note: If I use a regular element instead an iframe it becomes correctly focused.
Seems the following will fix it: +++ b/dom/base/nsContentUtils.cpp @@ -6148,7 +6148,7 @@ nsContentUtils::IsSubDocumentTabbable(nsIContent* aContent) { //XXXsmaug Shadow DOM spec issue! // We may need to change this to GetComposedDoc(). - nsIDocument* doc = aContent->GetUncomposedDoc(); + nsIDocument* doc = aContent->GetComposedDoc(); if (!doc) { return false; }
(I'm surprised anyone using the old v0 shadow DOM. But perhaps converting to the new slots based shadow DOM v1 won't be that hard when it becomes available. )
FWIW, we're using it in positron.
I see. That patch btw makes totally sense :) I don't recall if the spec has been fixed in this case though. So whoever reviews the patch needs to review the spec too and if it is still buggy, file a spec bug. I hope positron can later move to use the new syntax quite easily.
I'm interested in William's thoughts here.
Flags: needinfo?(wchen)
Whiteboard: btpp-followup-2016-07-05
Flags: needinfo?(william)
Priority: -- → P2
Whiteboard: btpp-followup-2016-07-05
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: