Closed
Bug 1281762
Opened 8 years ago
Closed 8 years ago
nsWindowRoot::mPopupNode may keep otherwise closed documents alive
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla50
People
(Reporter: smaug, Assigned: smaug)
References
Details
(Whiteboard: btpp-active)
Attachments
(1 file)
|
(deleted),
patch
|
enndeakin
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
I see a document being kept alive via nsWindowRoot::mPopupNode in child process.
http://searchfox.org/mozilla-central/rev/970569ad57ac4436ff31aa2ac63f38ed3ee2932d/layout/base/nsDocumentViewer.cpp#2695
->
http://searchfox.org/mozilla-central/source/dom/base/nsWindowRoot.cpp#379
|
Assignee | |
Comment 1•8 years ago
|
||
I think we could make mPopupNode a weak ref
|
|
Assignee | |
Comment 2•8 years ago
|
||
Assignee: nobody → bugs
Attachment #8764566 -
Flags: review?(enndeakin)
|
||
Updated•8 years ago
|
Attachment #8764566 -
Flags: review?(enndeakin) → review+
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a1a3f39c99b
nsWindowRoot::mPopupNode may keep otherwise closed documents alive, r=enn
|
|
Assignee | |
Comment 4•8 years ago
|
||
Comment on attachment 8764566 [details] [diff] [review]
patch
Approval Request Comment
[Feature/regressing bug #]: For e10s, bug 1058712
[User impact if declined]: higher memory consumption and slower cycle collections in some cases
[Describe test coverage new/current, TreeHerder]: NA
[Risks and why]: should be very safe.
[String/UUID change made/needed]: NA
Attachment #8764566 -
Flags: approval-mozilla-beta?
Attachment #8764566 -
Flags: approval-mozilla-aurora?
|
||
Updated•8 years ago
|
Whiteboard: btpp-active
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
|
||
Updated•8 years ago
|
status-firefox48:
--- → affected
status-firefox49:
--- → affected
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8764566 [details] [diff] [review]
patch
Improve the memory usage, taking it.
Should be in 48 beta 4
Attachment #8764566 -
Flags: approval-mozilla-beta?
Attachment #8764566 -
Flags: approval-mozilla-beta+
Attachment #8764566 -
Flags: approval-mozilla-aurora?
Attachment #8764566 -
Flags: approval-mozilla-aurora+
|
|
||
Comment 7•8 years ago
|
||
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•