This patch will fix the fullscreen issue on stalker.pl.

Comment on attachment 8764870 [details] [diff] [review] patch Trying another reviewer.

Comment on attachment 8764870 [details] [diff] [review] patch Review of attachment 8764870 [details] [diff] [review]: ----------------------------------------------------------------- The OLC stuff looks ok to me, but not sure I'm qualified to review the DocShell stuff (which looks ok to me but I'm not a DOM Peer). Might also be worth adding a test to make sure this stays working.

Test added.

Comment on attachment 8766423 [details] [diff] [review] embed_allowfullscreen - In dom/base/nsObjectLoadingContent.h: + // True if object represents an object/embed tag pointing to a flash embed + // for a youtube video. When possible (see IsRewritableYoutubeEmbed function + // comments for details), we change these to try to load HTML5 versions of + // videos. + bool mRewrittenYoutubeEmbed : 1; Please move this member declaration further down in the file so that it clusters with the other single bit boolean variables in this class. And while you're at it if you'd like you could make mHasRunID a single bit boolean too (just noticed it's not when looking at where this one should go). r=jst with that fixed. Thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/119a365358d598305fba487f5eacd4945a458c3f Bug 1282038 - Allow allowfullscreen for rewritten YouTube Flash embeds. r=qdot,jst

For the record.

Without this patch, the test will permafail when this change merges to beta because unprefixed fullscreen is not enabled on release builds yet.

https://hg.mozilla.org/integration/mozilla-inbound/rev/732d517ac4385204f7cabcea9316906bc48819f9 Bug 1282038 - Follow-up: Ensure unprefixed fullscreen API is enabled. r=me

Comment on attachment 8766578 [details] [diff] [review] patch for checkin Approval Request Comment [Feature/regressing bug #]: 769117 [User impact if declined]: Fullscreen will not work on some embedded YouTube movie. [Describe test coverage new/current, TreeHerder]: Automated test baked on m-c [Risks and why]: ow, only affects already broken YouTube embeds [String/UUID change made/needed]: none

Comment on attachment 8766578 [details] [diff] [review] patch for checkin Canceling the uplift request to beta because the depending uplift request has been canceled.

Comment on attachment 8766578 [details] [diff] [review] patch for checkin OK to uplift to aurora, but the work from bug 1258053 should land first.

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #14) > Comment on attachment 8766578 [details] [diff] [review] > patch for checkin > > OK to uplift to aurora, but the work from bug 1258053 should land first. bug 1258053 has conflicts, so waiting till this is resolved

https://hg.mozilla.org/releases/mozilla-aurora/rev/c0a5d404e987 https://hg.mozilla.org/releases/mozilla-aurora/rev/7051fecb8b51