Closed
Bug 1282418
Opened 8 years ago
Closed 8 years ago
[css-grid] calc() with negative percentage can result in negative track size
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla51
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
(deleted),
text/html
|
Details | |
(deleted),
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Loading this testcase triggers:
###!!! ASSERTION: inline-size less than zero: 'aContainingBlockISize >= 0', file layout/base/nsLayoutUtils.cpp, line 5215
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8765674 -
Flags: review?(dholbert)
Assignee | ||
Comment 3•8 years ago
|
||
Assignee | ||
Comment 4•8 years ago
|
||
BTW, we should probably sprinkle a few more "calc(1px - 99%)" in
property_database.js for properties that don't take negative values,
to increase the chance for fuzzers finding assertions like the one
above.
Comment 5•8 years ago
|
||
Comment on attachment 8765674 [details] [diff] [review]
fix
Review of attachment 8765674 [details] [diff] [review]:
-----------------------------------------------------------------
r=me
(Though I have minor concerns about the absolute-value flavoredness of the "AbsoluteSize()" name, which I expressed in bug 1279182 comment 9. They particularly apply to this bug here, since we're explicitly using this function to "deal with" negative values here. And AbsoluteSomething(MaybeNegativeValue) kinda sounds like it's going to take the absolute value, potentially.)
Attachment #8765674 -
Flags: review?(dholbert) → review+
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/266f03d1dd69
[css-grid] Deal with calc() with negative percentage that may result in negative track size. r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc68d1b0e247
[css-grid] Adding reftests for calc(Npx - M%) track sizes.
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/266f03d1dd69
https://hg.mozilla.org/mozilla-central/rev/dc68d1b0e247
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Assignee | ||
Updated•8 years ago
|
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•