Closed
Bug 1282691
Opened 8 years ago
Closed 7 years ago
Assertion failure: !IsWaitingToPause(aAnimation) (Animation is already waiting to pause)
Categories
(Core :: DOM: Animation, defect, P3)
Core
DOM: Animation
Tracking
()
RESOLVED
FIXED
mozilla58
People
(Reporter: jruderman, Assigned: birtles)
References
Details
(Keywords: assertion, testcase)
Attachments
(3 files)
No description provided.
Reporter | ||
Comment 1•8 years ago
|
||
Updated•8 years ago
|
Component: DOM → DOM: Animation
Assignee | ||
Updated•8 years ago
|
Priority: -- → P3
Comment 2•8 years ago
|
||
Testcase still asserts in mozilla-central 20170216-25929185c467
Assignee | ||
Comment 4•7 years ago
|
||
I suspect we're returning true from Animation::IsPossiblyOrphanedPendingAnimation because we're pause-pending but have no document.
Then, a few moments later, we're re-attached to the same document whose pending animation tracker has us registered as a pause-pending animation. However, our local pending state is "not pending" so we don't go and remove ourselves from the pending animation tracker as part of the CancelPendingTasks() step in the call to play().
So it sounds like we should replace the assertion with a step that removes us from the pause pending set. That's an extra hashtable lookup which is unfortunate but it's probably the best we can do.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•7 years ago
|
||
Comment hidden (mozreview-request) |
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8918158 [details]
Bug 1282691 - Drop the assertion about an animation that we're making play-pending not already being pause-pending;
https://reviewboard.mozilla.org/r/189014/#review194332
Attachment #8918158 -
Flags: review?(boris.chiou) → review+
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fe68b3629d17
Drop the assertion about an animation that we're making play-pending not already being pause-pending; r=boris
Comment 9•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Updated•7 years ago
|
status-firefox50:
affected → ---
status-firefox56:
--- → wontfix
status-firefox57:
--- → wontfix
status-firefox-esr52:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•