Closed
Bug 128282
Opened 23 years ago
Closed 23 years ago
[PATCH]Crash when loading http://gabber.sourceforge.net [@ nsImageWin::DrawTile]
Categories
(Core Graveyard :: GFX, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.9
People
(Reporter: mjw, Assigned: dcone)
References
()
Details
(Keywords: crash, topcrash)
Crash Data
Attachments
(2 files)
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
kmcclusk
:
review+
attinasi
:
superreview+
asa
:
approval+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:0.9.8+) Gecko/20020227
Reporter | ||
Comment 1•23 years ago
|
||
TB3477344E
Reporter | ||
Comment 2•23 years ago
|
||
TB3478107E
Crashed with me too, TB3478693Z.
If you disable images, it doesn't crash.
Reporter | ||
Comment 4•23 years ago
|
||
I've been through http://gabber.sourceforge.net/images and I can load every
image independently without moz crashing.
Is this linked with the null sized gif in this dir?
http://gabber.sourceforge.net/images/css.gif
Comment 6•23 years ago
|
||
-> Compositor (?) and confirming with win2k build 20020226..
Assignee: asa → kmcclusk
Status: UNCONFIRMED → NEW
Component: Browser-General → Compositor
Ever confirmed: true
Keywords: crash
QA Contact: doronr → petersen
Summary: Crash when loading http://gabber.sourceforge.net → Crash when loading http://gabber.sourceforge.net [@ nsImageWin::DrawTile]
Comment 7•23 years ago
|
||
Comment 8•23 years ago
|
||
wfm using build 2002022808 on Linux.
Might be a Windows-only bug ?
Comment 10•23 years ago
|
||
*** Bug 128324 has been marked as a duplicate of this bug. ***
Comment 11•23 years ago
|
||
*** Bug 123434 has been marked as a duplicate of this bug. ***
Comment 12•23 years ago
|
||
in bug 128282 i created attachment 71927 [details] which demonstrates the problem. it
crashes the browser in module 'gkgfxwin.dll'
some talkback IDs are: TB3486577M, TB3485969M, TB3441933K and others
my testcase simply does the following: use an image in the <link rel="shortcut
icon" type="image/png" href="..."> tag in the header and then also style an
(any) other element in the page content with the same image: voila there is the
crasher. if one removes one of the uses of the image, everything works fine.
the given URL doesn't seem to use it's shortcut icon elsewhere, but it seem to
be the same conditions which crash the browser. so my testcase should work for
this one, too.
Comment 13•23 years ago
|
||
the above bug number should have been bug 128324 of cause (dup'd in comment 10).
and pavlov also stated "dcone has been playing with the windows tiling code
recently.. over to him" there, so dcone seems to be the right owner.
Comment 14•23 years ago
|
||
*** Bug 128842 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 15•23 years ago
|
||
for some reason.. http://grabber.sourceforge.net went away while I was running
my tests.. but I use http://linuxgraphic.org which also crashed my machine. The
problem was we were doing the alpha blend with an optimized image.. which means
we did not have the bits for the blend. I fixed by converting back to a DDB. I
am copying Pavlov and Kevin so they can see what I did and can raise any issues
with how I fixed it. With the current patch.. the memory will go up.. until
something optimizes the image later.. but since it needs to be a DIB for
rendering.. I do not convert back to a DDB. This will only happend with Alpha
image with a depth of 8 bits. The only other question I have.. maybee we should
never optimize images with this depth alpha since they need the DIB information
for rendering.
Assignee | ||
Comment 16•23 years ago
|
||
Comment 17•23 years ago
|
||
Comment on attachment 72474 [details] [diff] [review]
Patch to convert from DDB to DIB for Alpha blend
Please change the if( mImageBits==0) with if(mImageBits)
r=kmcclusk@netscape.com
Attachment #72474 -
Flags: review+
Updated•23 years ago
|
Updated•23 years ago
|
Summary: Crash when loading http://gabber.sourceforge.net [@ nsImageWin::DrawTile] → [PATCH]Crash when loading http://gabber.sourceforge.net [@ nsImageWin::DrawTile]
Comment 18•23 years ago
|
||
Comment on attachment 72474 [details] [diff] [review]
Patch to convert from DDB to DIB for Alpha blend
sr=attinasi
Attachment #72474 -
Flags: superreview+
Comment 19•23 years ago
|
||
Kevin, you meant 'if(!mImageBits)', right?
Comment 20•23 years ago
|
||
oops! Yes, I just wanted the formulation of the statement to change not the
actual comparison.
Comment 21•23 years ago
|
||
Talkback data shows this crash last appeared with builds from 3/1. Has anyone
been able to reproduce this since then? It would be interesting to see if this
is being reported under a different stack signature now.
Comment 22•23 years ago
|
||
still happend on 2002030508/WinXP -> TalkbackID is TB3757518E
Comment 23•23 years ago
|
||
Comment on attachment 72474 [details] [diff] [review]
Patch to convert from DDB to DIB for Alpha blend
a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #72474 -
Flags: approval+
Comment 24•23 years ago
|
||
The patch was checked into the trunk.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 25•23 years ago
|
||
*** Bug 130599 has been marked as a duplicate of this bug. ***
Comment 26•23 years ago
|
||
*** Bug 130980 has been marked as a duplicate of this bug. ***
Comment 27•23 years ago
|
||
No incidents in Talkback data on the Trunk for the last ten days following
checkin. Good fix, Don.
Status: RESOLVED → VERIFIED
Comment 28•23 years ago
|
||
*** Bug 131985 has been marked as a duplicate of this bug. ***
Comment 29•23 years ago
|
||
*** Bug 137419 has been marked as a duplicate of this bug. ***
Updated•16 years ago
|
Product: Core → Core Graveyard
Updated•14 years ago
|
Crash Signature: [@ nsImageWin::DrawTile]
You need to log in
before you can comment on or make changes to this bug.
Description
•