Closed
Bug 1282881
Opened 8 years ago
Closed 8 years ago
Remove telemetry probe for the “Zoom Text Only” feature in Firefox 53
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: claas, Assigned: claas, Mentored)
Details
(Whiteboard: [measurement:client:tracking])
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
gfritzsche
:
review+
chutten
:
feedback+
|
Details | Diff | Splinter Review |
Background:
The userpref `browser.zoom.full` was added to environment telemetry in Firefox 50 (Bug 979323).
Goal of this bug:
Remove the userpref from environment telemetry again in Firefox 53.
Assignee | ||
Updated•8 years ago
|
Summary: Add telemetry probe for the “Zoom Text Only” feature. → Remove telemetry probe for the “Zoom Text Only” feature.
Assignee | ||
Updated•8 years ago
|
Whiteboard: [measurement:client:tracking]
Updated•8 years ago
|
Summary: Remove telemetry probe for the “Zoom Text Only” feature. → Remove telemetry probe for the “Zoom Text Only” feature in Firefox 53
Comment 1•8 years ago
|
||
Nightly is now on 53: http://whattrainisitnow.com/
Claas, do you want to take this?
Flags: needinfo?(mozilla)
Assignee | ||
Comment 2•8 years ago
|
||
Georg, thanks for the ping, I gladly take this.
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Flags: needinfo?(mozilla)
Updated•8 years ago
|
Mentor: gfritzsche
Assignee | ||
Comment 3•8 years ago
|
||
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8816578 [details] [diff] [review]
Remove telemetry probe for the “Zoom Text Only” feature in Firefox 53
I have reversed the changes [0] from Bug 979323.
[0] https://bugzilla.mozilla.org/attachment.cgi?id=8765186
Attachment #8816578 -
Flags: review?(gfritzsche)
Comment 5•8 years ago
|
||
Comment on attachment 8816578 [details] [diff] [review]
Remove telemetry probe for the “Zoom Text Only” feature in Firefox 53
Review of attachment 8816578 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/components/telemetry/docs/data/environment.rst
@@ -323,5 @@
> - ``browser.urlbar.suggest.searches``: True if search suggestions are enabled in the urlbar. Defaults to false.
>
> - ``browser.urlbar.userMadeSearchSuggestionsChoice``: True if the user has clicked Yes or No in the urlbar's opt-in notification. Defaults to false.
>
> -- ``browser.zoom.full``: True if zoom is enabled for both text and images, that is if "Zoom Text Only" is not enabled. Defaults to true. Collection of this preference has been enabled in Firefox 50 and will be disabled again in Firefox 53 (`Bug 979323 <https://bugzilla.mozilla.org/show_bug.cgi?id=979323>`_).
We don't have a great approach yet on how to document environment data points that were removed again for future data investigations.
Can we leave this in for now as:
> - ``browser.zoom.full`` (deprecated): was enabled in ... and was disabled in ...
Attachment #8816578 -
Flags: review?(gfritzsche) → feedback+
Assignee | ||
Comment 6•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8816578 -
Attachment is obsolete: true
Assignee | ||
Comment 7•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8818353 -
Attachment is obsolete: true
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8818357 [details] [diff] [review]
Remove telemetry probe for the “Zoom Text Only” feature in Firefox 53
Remove pref from TelemetryEnvironment, but keep updated version of data point documentation.
PS: For the sake of readability, I chose a more concise wording, omitting the enable/disable terms.
Attachment #8818357 -
Flags: review?(gfritzsche)
Updated•8 years ago
|
Attachment #8818357 -
Flags: feedback+
Comment 9•8 years ago
|
||
Comment on attachment 8818357 [details] [diff] [review]
Remove telemetry probe for the “Zoom Text Only” feature in Firefox 53
Review of attachment 8818357 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #8818357 -
Flags: review?(gfritzsche) → review+
Updated•8 years ago
|
Keywords: checkin-needed
Comment 10•8 years ago
|
||
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4c4def343fe
Remove telemetry probe for the “Zoom Text Only” feature in Firefox 53. r=gfritzsche
Keywords: checkin-needed
Comment 11•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•