Closed
Bug 1283022
Opened 8 years ago
Closed 8 years ago
Implement the min and max attribute for <input type=month>
Categories
(Core :: DOM: Core & HTML, defect, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: jessica, Assigned: jessica)
References
Details
(Whiteboard: btpp-active)
Attachments
(1 file)
|
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → jjong
|
||
Updated•8 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 1•8 years ago
|
||
|
|
Assignee | |
Updated•8 years ago
|
Whiteboard: btpp-active
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8771265 -
Flags: review?(bugs)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8771265 [details] [diff] [review]
patch, v1.
>+ case 'month':
>+ input.value = '2016-06';
>+ checkValidity(input, true, apply, apply);
>+
>+ input.value = '2016-12';
>+ checkValidity(input, true, apply, apply);
>+
>+ input.value = 'foo';
>+ checkValidity(input, true, apply, apply);
It always surprises me how invalid values are handled when one assigns such to .value (.value becomes "" after assigning "foo", right?);
Attachment #8771265 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #2)
> Comment on attachment 8771265 [details] [diff] [review]
> patch, v1.
>
> >+ case 'month':
> >+ input.value = '2016-06';
> >+ checkValidity(input, true, apply, apply);
> >+
> >+ input.value = '2016-12';
> >+ checkValidity(input, true, apply, apply);
> >+
> >+ input.value = 'foo';
> >+ checkValidity(input, true, apply, apply);
> It always surprises me how invalid values are handled when one assigns such
> to .value (.value becomes "" after assigning "foo", right?);
Right, if the value is not a valid month string, we set it to the empty string instead.
|
|
Assignee | |
Comment 4•8 years ago
|
||
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/564fdbb916ba
Implement the min and max attribute for <input type=month>. r=smaug
Keywords: checkin-needed
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•