Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] Assignee
	Description • 8 years ago

      No description provided.

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] Assignee
	Comment 2 • 8 years ago

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c9185963cfb

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] Assignee
	Comment 3 • 8 years ago

New try push on top of fixed blocker patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=182f4b04f807

	Terrence Cole [:terrence]
	Comment 4 • 8 years ago

Comment on attachment 8766472 [details] [diff] [review]
Use js::Mutex and js::ConditionVariable instead of PRLock and PRCondVar in HelperThreads

Review of attachment 8766472 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/HelperThreads.h
@@ +470,5 @@
>  
>  class MOZ_RAII AutoUnlockHelperThreadState
>  {
> +    // This is only in a Maybe so that we can update the DEBUG-only lockOwner
> +    // thread in the proper order :-/

First, use a period instead of a meh.

Secondly, could we move the owner-tracking code into js::Mutex? It seems like it would simplify a lot of the code in our tree, since all three of them are currently tracking the owner manually. Maybe for a followup.

	Pulsebot
	Comment 5 • 8 years ago

Pushed by nfitzgerald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c62dc1a368c8
Use js::Mutex and js::ConditionVariable instead of PRLock and PRCondVar in HelperThreads; r=terrence

	Carsten Book [:Tomcat]
	Comment 6 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/c62dc1a368c8