Closed Bug 1283400 Opened 8 years ago Closed 8 years ago

[TV][2.6][FTE] Remove 'Home intro' and 'Pin to home' from TV FTE

Categories

(Firefox OS Graveyard :: Gaia::TV, defect, P2)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:2.6+, b2g-v2.6 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g 2.6+
Tracking Flags:
Tracking Status
b2g-v2.6 --- fixed

People

(Reporter: mlien, Assigned: Fischer)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

[gaia] Fischer-L:bug_1283400-remove-home-fte > mozilla-b2g:v2.6
(deleted), text/x-github-pull-request
rexboy
: review+
jocheng
: approval-gaia-v2.6+
Details
v2.5 remove TV FTE and keep it on master, do we still need it on v2.6? +++ This bug was initially created as a clone of Bug #1240415 +++ Following 3 parts will be removed from TV FTE: • Home intro. • Info frame intro. (Not implemented) • Pin to home Discussed with partner on-site and decide to remove them because we need to consider l10n issues. Please remove 'Home intro' and 'Pin to home' from TV FTE
Fischer, could you check if any patch is missing in v2.6? Thanks.
blocking-b2g: 2.6? → 2.6+
Flags: needinfo?(fliu)
@Josh, In the bug 1240415, The 2 FTE pages (Home intro and Pin to home) has been removed in v2.5. Also need to remove these 2 FTE pages in v2.6 ? Thanks
Flags: needinfo?(fliu) → needinfo?(jocheng)
(In reply to [:Fischer]Fischer from comment #2) > @Josh, > In the bug 1240415, The 2 FTE pages (Home intro and Pin to home) has been > removed in v2.5. > Also need to remove these 2 FTE pages in v2.6 ? > Thanks Yes, Please
Flags: needinfo?(jocheng) → needinfo?(fliu)
Comment on attachment 8767836 [details] [gaia] Fischer-L:bug_1283400-remove-home-fte > mozilla-b2g:v2.6 @Rex, Like the bug 1240415, this patch removes "Home intro" and "Pin to home" FTE parts. Thanks.
Flags: needinfo?(fliu)
Attachment #8767836 - Flags: review?(rexboy)
Comment on attachment 8767836 [details] [gaia] Fischer-L:bug_1283400-remove-home-fte > mozilla-b2g:v2.6 r+ for patch uplifting
Attachment #8767836 - Flags: review?(rexboy) → review+
Assignee: nobody → fliu
Comment on attachment 8767836 [details] [gaia] Fischer-L:bug_1283400-remove-home-fte > mozilla-b2g:v2.6 [Approval Request Comment] [Bug caused by] (feature/regressing bug #):1283400 [User impact] if declined: User would see unnecessary FTE parts [Testing completed]: Yes [Risk to taking this patch] (and alternatives if risky): Low [String changes made]: None
Attachment #8767836 - Flags: approval-gaia-v2.6?(jocheng)
Comment on attachment 8767836 [details] [gaia] Fischer-L:bug_1283400-remove-home-fte > mozilla-b2g:v2.6 Approve for TV 2.6
Attachment #8767836 - Flags: approval-gaia-v2.6?(jocheng) → approval-gaia-v2.6+
Land to v2.6: https://github.com/mozilla-b2g/gaia/commit/85cb39d8c8770827779cb5a7a345b7eef3cdae73
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: