Closed
Bug 1283439
Opened 8 years ago
Closed 8 years ago
../../dist/include/mozilla/layers/LayersTypes.h:146:12: error: 'sp' in namespace 'android' does not name a template type
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox50 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
text/x-review-board-request
|
kinetik
:
review+
|
Details |
No description provided.
|
Assignee | |
Updated•8 years ago
|
Summary: ../../dist/include/mozilla/layers/LayersTypes.h:124:12: error: 'mSurface' was not declared in this scope → ../../dist/include/mozilla/layers/LayersTypes.h:146:12: error: 'sp' in namespace 'android' does not name a template type
|
|
Assignee | |
Comment 1•8 years ago
|
||
|
|
Assignee | |
Comment 2•8 years ago
|
||
(In reply to Alexandre LISSY :gerard-majax from comment #1)
> Created attachment 8766802 [details] [diff] [review]
> difference between gonk's StrongPointer.h and the copy in
> media/libstagefright living in Gecko tree
This comes from bug 908503 attachment 8422882 [details] [diff] [review] and is explicitely done to keep things apart
|
|
Assignee | |
Comment 3•8 years ago
|
||
We get to include LayersTypes.h from that MP4 parsing just because of the Rust parser added in bug 1267887 and the sharing operated in bug 1282963. The OpusDataDecoder class is only used in side the MP4MetadataRust::GetTrackInfo method and thus we can just avoid including OpusDecoder.h when MOZ_RUST_MP4PARSE is not defined.
Blocks: 1282963
|
|
Assignee | |
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/61574/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61574/
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → lissyx+mozillians
|
|
Assignee | |
Comment 5•8 years ago
|
||
Comment on attachment 8766849 [details]
Bug 1283439 - Include OpusDecoder.h only for Rust MP4 parsing
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61574/diff/1-2/
Attachment #8766849 -
Flags: review?(kinetik)
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8766849 [details]
Bug 1283439 - Include OpusDecoder.h only for Rust MP4 parsing
https://reviewboard.mozilla.org/r/61574/#review58554
Attachment #8766849 -
Flags: review?(kinetik) → review+
Pushed by alissy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4c2575a96e8
Include OpusDecoder.h only for Rust MP4 parsing r=kinetik
|
|
Assignee | |
Comment 8•8 years ago
|
||
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•