User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:49.0) Gecko/20100101 Firefox/49.0 Build ID: 20160703004019 Steps to reproduce: ./mach build Actual results: build fails Expected results: build succeed

The exact error is 0:29.28 /Users/ojab/Documents/repos/mozilla-central/js/src/threading/posix/ConditionVariable.cpp:77:12: error: use of undeclared identifier 'pthread_condattr_setclock'; did you mean 'pthread_condattr_setpshared'? 0:29.28 int r1 = pthread_condattr_setclock(&attr, WhichClock); 0:29.28 ^~~~~~~~~~~~~~~~~~~~~~~~~ 0:29.28 pthread_condattr_setpshared 0:29.29 /usr/include/pthread.h:322:5: note: 'pthread_condattr_setpshared' declared here 0:29.29 int pthread_condattr_setpshared(pthread_condattr_t *, int); 0:29.29 ^ 0:29.29 1 error generated. 0:29.29 0:29.29 In the directory /Users/ojab/Documents/repos/mozilla-central/obj-x86_64-apple-darwin16.0.0/js/src 0:29.29 The following command failed to execute properly: 0:29.29 /usr/bin/clang++ -std=gnu++11 -o ConditionVariable.o -c -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DENABLE_BINARYDATA -DENABLE_SIMD -DENABLE_SHARED_ARRAY_BUFFER -DEXPORT_JS_API -DJS_HAS_CTYPES -DDLL_PREFIX="lib" -DDLL_SUFFIX=".dylib" -DFFI_BUILDING -I/Users/ojab/Documents/repos/mozilla-central/js/src -I/Users/ojab/Documents/repos/mozilla-central/obj-x86_64-apple-darwin16.0.0/js/src -I/Users/ojab/Documents/repos/mozilla-central/obj-x86_64-apple-darwin16.0.0/js/src/ctypes/libffi/include -I/Users/ojab/Documents/repos/mozilla-central/intl/icu/source/common -I/Users/ojab/Documents/repos/mozilla-central/intl/icu/source/i18n -I/Users/ojab/Documents/repos/mozilla-central/obj-x86_64-apple-darwin16.0.0/dist/include -I/Users/ojab/Documents/repos/mozilla-central/obj-x86_64-apple-darwin16.0.0/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /Users/ojab/Documents/repos/mozilla-central/obj-x86_64-apple-darwin16.0.0/js/src/js-confdefs.h -MD -MP -MF .deps/ConditionVariable.o.pp -Qunused-arguments -Qunused-arguments -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wc++11-compat-pedantic -Wc++14-compat -Wc++14-compat-pedantic -Wc++1z-compat -Wclass-varargs -Wimplicit-fallthrough -Wloop-analysis -Wstring-conversion -Wthread-safety -Wno-invalid-offsetof -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-common -stdlib=libc++ -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe -g -O3 -fno-stack-protector -fomit-frame-pointer -Wno-shadow /Users/ojab/Documents/repos/mozilla-central/js/src/threading/posix/ConditionVariable.cpp 0:29.29 make[5]: *** [ConditionVariable.o] Error 1 0:29.30 make[4]: *** [js/src/target] Error 2 0:29.30 make[4]: *** Waiting for unfinished jobs....

fixed bug number in commit message

Comment on attachment 8767592 [details] [diff] [review] sierra_js.patch Review of attachment 8767592 [details] [diff] [review]: ----------------------------------------------------------------- Thank you for the fix!

Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/43b1143f2930 Don't USE_CLOCK_API on macOS. r=terrence

Comment on attachment 8767592 [details] [diff] [review] sierra_js.patch Approval Request Comment [Feature/regressing bug #]: macOS 10.12 Sierra [User impact if declined]: Developers who work on 10.12 will not be able to compile Firefox, for example when they want to test their fixes for uplift on release branches [Describe test coverage new/current, TreeHerder]: none, we don't have automatic builders on 10.12 yet [Risks and why]: extremely low, the patch is just making sure that the #ifdef works on 10.12 the way it did on 10.11. [String/UUID change made/needed]: none

Comment on attachment 8767592 [details] [diff] [review] sierra_js.patch Review of attachment 8767592 [details] [diff] [review]: ----------------------------------------------------------------- It's too late for 48 beta. Let's let it ride the train on 49 and not fix in 48 to mitigate the risks on the release.

Could this affect FF45 ESR as well?