Closed
Bug 1284433
Opened 8 years ago
Closed 2 years ago
Don't overlap checkbox and marker in performance-filter-menupopup
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)
Tracking
(firefox-esr52 wontfix)
RESOLVED
WONTFIX
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | wontfix |
People
(Reporter: magicp.jp, Unassigned)
References
Details
(Keywords: regression, Whiteboard: [good taipei bug][lang=css])
Attachments
(1 file)
(deleted),
image/png
|
Details |
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160704030211
Steps to reproduce:
1. Start Nightly in Windows
2. Open DevTools > Performance
3. Open the performance filter
Actual results:
checkbox and marker are overlapped.
Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=975d97ff77ae82b113b66d2a46dc30fc654f411a&tochange=c0edf384327531b1e302c61fa3c77cf966152182
Expected results:
Don't overlap checkbox and marker.
Blocks: 1172412
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox49:
--- → unaffected
status-firefox50:
--- → affected
Component: Untriaged → Developer Tools: Performance Tools (Profiler/Timeline)
OS: Unspecified → Windows
Hardware: Unspecified → All
Updated•8 years ago
|
Priority: -- → P1
status-firefox51:
--- → affected
Comment 1•8 years ago
|
||
One thing to try is adding start padding on .menu-iconic-text then using a background-image to emulate the square (probably with a solid linear-gradient and a fixed background size and position).
Mentor: ntim.bugs
Whiteboard: [good taipei bug][lang=css]
Comment 2•8 years ago
|
||
Looks good on latest nightly
Version 51.0a1
Build ID 20160810150918
User Agent Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
OS Linux 4.2.0-42-generic
Can anyone verify ??
Flags: needinfo?(ntim.bugs)
Comment 3•8 years ago
|
||
(In reply to [:Towkir] Ahmed from comment #2)
> Looks good on latest nightly
>
> Version 51.0a1
> Build ID 20160810150918
> User Agent Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101
> Firefox/51.0
> OS Linux 4.2.0-42-generic
>
> Can anyone verify ??
The issue is on Windows.
Flags: needinfo?(ntim.bugs) → needinfo?(3ugzilla)
Comment 4•8 years ago
|
||
Ok, but is there different styling for different platform ? I mean different performance.css files ?
Flags: needinfo?(3ugzilla)
Comment 5•8 years ago
|
||
I have reproduced this bug with Nightly 50.0a1 (2016-07-05)
Build ID 20160705030222
User Agent Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0
Comment 6•8 years ago
|
||
As per the DevTools triage process doc [1], a P1 is defined as:
- a security hole
- causing data-loss
- causing a crash
- stopping the tools working
- embarrassing
Should be fixed within 24h and your manager should know about it and, between you, assign it to someone who can fix it.
This bug has been set to P1 more than 3 months ago and is still unassigned. I don't think it's that bad that it needs to be a P1.
[1] https://docs.google.com/document/d/1uG0foc0pphXJB489_8ClKjYr1wbRXeFyrkd_kIOv9ao/edit#
Priority: P1 → P2
status-firefox52:
--- → affected
Comment 7•8 years ago
|
||
Mass wontfix for bugs affecting firefox 52.
Comment 8•7 years ago
|
||
Hi
I am interested in taking this bug. Please let me know if i can take this one or suggest other bugs as I am a newbie.
status-firefox56:
--- → wontfix
status-firefox57:
--- → affected
status-firefox58:
--- → affected
status-firefox-esr52:
--- → wontfix
Updated•6 years ago
|
Product: Firefox → DevTools
Hi
I am interested in taking this bug.
status-firefox49:
unaffected → ---
status-firefox50:
affected → ---
status-firefox51:
affected → ---
status-firefox52:
wontfix → ---
status-firefox56:
wontfix → ---
status-firefox57:
affected → ---
status-firefox58:
affected → ---
Updated•6 years ago
|
Mentor: ntim.bugs
Comment 10•6 years ago
|
||
Hey Irina,
sure, please do! I added you as the assignee for this bug.
The code for the performance tool is in /devtools/client/performance [1], but maybe the filter component is shared elsewhere.
You can also find a lot of documentation about how to develop in the devtools codebase in [2]. I encourage you to follow the steps outlined in this documentation.
I don't know the codebase well enough to give you directions, but I can have a look if you need it. Please add a "needinfo" request if you need anything.
[1] https://searchfox.org/mozilla-central/source/devtools/client/performance
[2] https://docs.firefox-dev.tools/
Thanks again for your help !
Assignee: nobody → irina6793
Updated•6 years ago
|
Assignee: irina6793 → nobody
Comment 11•2 years ago
|
||
Now that we replaced the old performance panel by the Firefox Profiler (see Bug 1668219) we're closing bugs related to this. If you see similar issues on the new profiler, please file another bug, and we'll be happy to have a look.
Filter on MASSCLOSEOLDPERFTOOLBUGS.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
Updated•2 years ago
|
Keywords: regression
You need to log in
before you can comment on or make changes to this bug.
Description
•