Closed Bug 1284535 Opened 8 years ago Closed 8 years ago

[pine => m-c] Remove mozApps dependency from AudioChannel

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox50 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1284535 - Remove dependencies to the mozApps-related APIs from the audio channel code
(deleted), text/x-review-board-request
gsvelto
: review+
Details
No description provided.
Summary: Remove mozApps dependency from AudioChannel → [pine => m-c] Remove mozApps dependency from AudioChannel
Conflicts: dom/browser-element/BrowserElementAudioChannel.cpp dom/browser-element/BrowserElementParent.js dom/browser-element/mochitest/browserElement_ActiveStateChangeOnChangingMutedOrVolume.js dom/messages/SystemMessagePermissionsChecker.jsm dom/system/gonk/AudioChannelManager.cpp Review commit: https://reviewboard.mozilla.org/r/62394/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/62394/
Attachment #8768032 - Flags: review?(gsvelto)
Attachment #8768033 - Flags: review?(gsvelto)
Conflicts: dom/browser-element/mochitest/browserElement_ActiveStateChangeOnChangingMutedOrVolume.js Review commit: https://reviewboard.mozilla.org/r/62396/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/62396/
There were some conflicts around cherry-picking those, I would feel safer if you could have a look at them. This is on top of bug 1284455. Please note that dom/browser-element/mochitest/browserElement_ActiveStateChangeOnChangingMutedOrVolume.js got renamed into dom/browser-element/mochitest/browserElement_ActiveStateChange.js by some other patch
Comment on attachment 8768032 [details] Bug 1284535 - Remove dependencies to the mozApps-related APIs from the audio channel code Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62394/diff/1-2/
Comment on attachment 8768033 [details] Bug 1284535 - Fix detection of the system app when dealing with audio channels and fix the associated tests Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62396/diff/1-2/
Comment on attachment 8768032 [details] Bug 1284535 - Remove dependencies to the mozApps-related APIs from the audio channel code https://reviewboard.mozilla.org/r/62394/#review59362 It looks good to me but let's wait for the try run to finish just to be sure.
Attachment #8768032 - Flags: review?(gsvelto) → review+
Comment on attachment 8768033 [details] Bug 1284535 - Fix detection of the system app when dealing with audio channels and fix the associated tests https://reviewboard.mozilla.org/r/62396/#review59364 It looks good to me but let's wait for the try run to finish just to be sure.
Attachment #8768033 - Flags: review?(gsvelto) → review+
Comment on attachment 8768032 [details] Bug 1284535 - Remove dependencies to the mozApps-related APIs from the audio channel code Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62394/diff/2-3/
Attachment #8768033 - Attachment is obsolete: true
Pushed by alissy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/04420d139399 Remove dependencies to the mozApps-related APIs from the audio channel code r=gsvelto
https://hg.mozilla.org/mozilla-central/rev/04420d139399
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: