There is a limit param in cropString() but no way to set it from the outside https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/components/reps/string.js#60 Honza said: I think we could do two things here: 1) Create a new property in StringRep called: cropLimit (or something like that) and pass it into: cropMultipleLines(text, this.prop.cropLimit). 2) Cover that in a test.

Review commit: https://reviewboard.mozilla.org/r/63446/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/63446/

Comment on attachment 8769620 [details] Bug 1284673 - Reps: add a cropLimit property to string rep; https://reviewboard.mozilla.org/r/63446/#review60324 Overall this looks good! Only one nit below, once that's done I think this should be good to go. I triggered a try build. ::: devtools/client/shared/components/reps/string.js:33 (Diff revision 1) > "\"" + text + "\"" > ) > ); > } > > + let cropLimitStr = this.props.cropLimit ? The variable name was a little confusing to me. I'd say something like croppedString here.

Comment on attachment 8769620 [details] Bug 1284673 - Reps: add a cropLimit property to string rep; Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63446/diff/1-2/

Thanks for review! variable name changed and all test passed.

Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/14881be4f436 Reps: add a cropLimit property to string rep; r=linclark