Closed Bug 1284793 Opened 8 years ago Closed 8 years ago

Cannot add/switch/delete tab from tab list

Categories

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::Browser
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:2.6+, b2g-v2.6 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g 2.6+
Tracking Flags:
Tracking Status
b2g-v2.6 --- fixed

People

(Reporter: mlien, Assigned: danhuang)

References

Details

(Keywords: regression, Whiteboard: [ft:conndevices])

Attachments

(1 file)

[gaia] danhuang1202:v2.6_1284793 > mozilla-b2g:v2.6
(deleted), text/x-github-pull-request
lchang
: review+
jocheng
: approval-gaia-v2.6+
Details
[Testing Steps] 1. Launch Browser 2. Invoke tab list 3. Add/Switch/Delete tab [Expected result] Add/Switch/Delete tab normally [Actual result] Add/Switch/Delete tab doesn't work [Build Info] Environment: 2.6 Nexus Player gaia: https://github.com/mozilla-b2g/gaia/commit/e8bb381435f869a32b4656ecc050f87fbd66b19e gecko: https://github.com/mozilla-b2g/gecko-b2g/commit/a06eefe6445d36934d77accd442ee4ffa14ef19d
Assignee: nobody → dhuang
Status: NEW → ASSIGNED
Hi Mike, I can't reproduce this bug on the lasted v2.6 branch. It seems all tab operations are work well on mulet. I think it would be better if you could borrow me the Nexus Player with v2.6 branch. what do you think?
Flags: needinfo?(mlien)
Sure, you can come and take it any time when you need it. Simulator can also reproduce this issue, below is the simulator build for firefox nightly on linux. http://mtbf-10.ateam.tpe1.mozilla.com:8081/view/Smart_TV/job/tv_build_simulator_v26/lastSuccessfulBuild/artifact/
Flags: needinfo?(mlien)
Comment on attachment 8769586 [details] [gaia] danhuang1202:v2.6_1284793 > mozilla-b2g:v2.6 Please review this patch. This patch update className.contains() to classList.contains(). Thanks.
Attachment #8769586 - Flags: review?(lchang)
Comment on attachment 8769586 [details] [gaia] danhuang1202:v2.6_1284793 > mozilla-b2g:v2.6 Makes sense! Thanks.
Attachment #8769586 - Flags: review?(lchang) → review+
Thanks for the review. Merge in v2.6: https://github.com/mozilla-b2g/gaia/commit/a7cfc9510e209e220dabbb831d50b3853f4fd468
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
blocking-b2g: 2.6? → 2.6+
Hi Dan, Please raise 2.6 uplift approval. Thanks
Flags: needinfo?(dhuang)
status-b2g-v2.6: --- → fixed
Flags: needinfo?(dhuang)
Comment on attachment 8769586 [details] [gaia] danhuang1202:v2.6_1284793 > mozilla-b2g:v2.6 [Approval Request Comment] [Bug caused by] (feature/regressing bug #): TV 2.6 [User impact] if declined: tab operation wouldn't work correctly [Testing completed]: Yes [Risk to taking this patch] (and alternatives if risky): None [String changes made]: None
Attachment #8769586 - Flags: approval-gaia-v2.6?
Comment on attachment 8769586 [details] [gaia] danhuang1202:v2.6_1284793 > mozilla-b2g:v2.6 Approve for Tv 2.6
Attachment #8769586 - Flags: approval-gaia-v2.6? → approval-gaia-v2.6+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: