Closed
Bug 1284839
Opened 8 years ago
Closed 8 years ago
Reps: Handle spaces between title and rep
Categories
(DevTools :: Shared Components, enhancement, P1)
DevTools
Shared Components
Tracking
(firefox50 affected, firefox51 fixed)
People
(Reporter: linclark, Assigned: Honza)
References
Details
(Whiteboard: [devtools-html])
Attachments
(1 file)
|
(deleted),
patch
|
linclark
:
review+
|
Details | Diff | Splinter Review |
Some reps do this, but we should make it uniform. There should always be a space after the title if it's followed by something.
|
||
Updated•8 years ago
|
Blocks: devtools-html-2
|
|
||
Updated•8 years ago
|
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [devtools-html] [triage] → [devtools-html]
|
||
Comment 1•8 years ago
|
||
I would like to work on this bug. It would be great if you help me where to start with?
|
Reporter | |
Comment 2•8 years ago
|
||
We have a few more bugs that need to land before this one is ready. I added the issue tracking those as a blocker to this one.
Depends on: 1257552
|
|
||
Comment 3•8 years ago
|
||
As the blocker for this one is resolved Can I start working on this bug ?
|
|
||
Updated•8 years ago
|
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Iteration: --- → 51.2 - Aug 29
Priority: P2 → P1
|
Assignee | |
Comment 4•8 years ago
|
||
Attachment #8785985 -
Flags: review?(lclark)
|
|
Reporter | |
Comment 5•8 years ago
|
||
Comment on attachment 8785985 [details] [diff] [review]
bug1284839.patch
Review of attachment 8785985 [details] [diff] [review]:
-----------------------------------------------------------------
This looks good to me, and it's green on try, so I think it's good to go.
Attachment #8785985 -
Flags: review?(lclark) → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/71d195130d77
Reps: Handle spaces between title and rep. r=linclark
Keywords: checkin-needed
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•