Closed
Bug 1284854
Opened 8 years ago
Closed 7 years ago
Reps: make sure function title shows up correctly
Categories
(DevTools :: Shared Components, enhancement, P3)
DevTools
Shared Components
Tracking
(firefox50 affected)
RESOLVED
WORKSFORME
Tracking | Status | |
---|---|---|
firefox50 | --- | affected |
People
(Reporter: linclark, Unassigned)
References
Details
(Whiteboard: [reserve-html])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
linclark
:
review-
|
Details | Diff | Splinter Review |
When the object link patch lands, if an objectLink prop is provided, then an anonymous function will show up as functionfunction().
Updated•8 years ago
|
Blocks: devtools-html-2
Flags: qe-verify-
Updated•8 years ago
|
Priority: -- → P2
Whiteboard: [devtools-html] [triage] → [devtools-html]
Comment 1•8 years ago
|
||
could you provide the dependent bug(object link patch) and the expect result (compared to functionfunction())?
Flags: needinfo?(lclark)
Reporter | ||
Comment 2•8 years ago
|
||
I've added the dependent bug. Once that lands, the output should be changed so that it displays function() or function ()... but the word function should be wrapped in the object link.
Depends on: 1283123
Flags: needinfo?(lclark)
Comment 3•8 years ago
|
||
Can I work on this bug ? Is it assigned to someone ?
Reporter | ||
Comment 4•8 years ago
|
||
It is not assigned to anyone so feel free to take it.
Comment 5•8 years ago
|
||
how do I test my changes whether they are working or not ?
Comment 6•8 years ago
|
||
I dont have any test cases to test it . Can you provide me with steps to reproduce the bug
Attachment #8772827 -
Flags: review?(lclark)
Updated•8 years ago
|
Assignee: nobody → hems.india1997
Status: NEW → ASSIGNED
Iteration: --- → 50.4 - Aug 1
Priority: P2 → P1
Reporter | ||
Comment 7•8 years ago
|
||
There are two cases that you have to test. One is where no object link is provided. This is the case in the DOM Panel. The other case is where an object link is provided. This is the case in the web console. To test it in the web console, you have to be using the Nightly version of Firefox and turn on the devtools.webconsole.new-frontend-enabled flag.
Reporter | ||
Comment 8•8 years ago
|
||
Comment on attachment 8772827 [details] [diff] [review]
Bug1284854 - Reps: make sure function title shows up correctly r=linclark
Review of attachment 8772827 [details] [diff] [review]:
-----------------------------------------------------------------
The patch attached won't cover both those cases, so I'm clearing the review for now.
Attachment #8772827 -
Flags: review?(lclark)
Comment 9•8 years ago
|
||
(In reply to Lin Clark [:linclark] from comment #7)
> There are two cases that you have to test. One is where no object link is
> provided. This is the case in the DOM Panel. The other case is where an
> object link is provided. This is the case in the web console. To test it in
> the web console, you have to be using the Nightly version of Firefox and
> turn on the devtools.webconsole.new-frontend-enabled flag.
I tried the Second One and its working.Can you please check the second one? Also, I think one test needs to be updated as well the "test_reps_function.html" one. Any comments on that?
Comment 10•8 years ago
|
||
Also I tried declaring a function like this
> x = new Function();
then it shows up as function anonymous() in console log and x() in DOM. Is there any other way to declare Anonymous function so as to check it in the DOM panel?
I tried this thing
> (function (msg){alert(msg)});
in console log and it showed a link as function (). However it did not show anything in DOM panel even if I refreshed it.
Comment 11•8 years ago
|
||
Also it is not clear what does DOM Panel show (or should show) when an anonymous function is called?
Flags: needinfo?(lclark)
Reporter | ||
Comment 12•8 years ago
|
||
I don't know of a good example in the DOM Panel. This might be too tricky to tackle right now.
Flags: needinfo?(lclark)
Comment 13•8 years ago
|
||
This Patch covers the case II ( when an object link is provided. ) of the bug. I tested it and it worked. Please check If I am wrong somewhere.
Attachment #8772827 -
Attachment is obsolete: true
Attachment #8775012 -
Flags: review?(lclark)
Reporter | ||
Comment 14•8 years ago
|
||
Comment on attachment 8775012 [details] [diff] [review]
Bug1284854 - Reps: make sure function title shows up correctly r=linclark
Review of attachment 8775012 [details] [diff] [review]:
-----------------------------------------------------------------
This patch would break a different case. As I mentioned in the comment above, I think this one might be too hard to explain. However, there is another good issue to work on, https://bugzilla.mozilla.org/show_bug.cgi?id=1284843. You can see the steps that need to be done in the last comment on that issue.
Attachment #8775012 -
Flags: review?(lclark) → review-
Updated•8 years ago
|
Iteration: 50.4 - Aug 1 → 51.1 - Aug 15
Updated•8 years ago
|
Iteration: 51.1 - Aug 15 → 51.2 - Aug 29
Comment 15•8 years ago
|
||
Hello Hemanth, following up if you are still interested in completing this bug or can it be reassigned?
Flags: needinfo?(hems.india1997)
Comment 16•8 years ago
|
||
(In reply to Marco Mucci [:MarcoM] from comment #15)
> Hello Hemanth, following up if you are still interested in completing this
> bug or can it be reassigned?
I am interested in it. But as Lin clark mentioned my patch would break a different case I am waiting for the dependant bug (if any) to be resolved. If its ready to be worked on, I will definitely love to work on this one.
Comment 17•8 years ago
|
||
Hi Lin, following up if this bug can proceed given the dependency (bug 1283123) has been completed or is there another dependency that is required?
Flags: needinfo?(hems.india1997) → needinfo?(lclark)
Reporter | ||
Comment 18•8 years ago
|
||
There are a few things in the air right now that will impact this, so I think we should put it on the back burner for now.
Assignee: hems.india1997 → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(lclark)
Updated•8 years ago
|
Iteration: 51.2 - Aug 29 → ---
Priority: P1 → P3
Whiteboard: [devtools-html] → [reserve-html]
Comment 19•7 years ago
|
||
Entering `() => {}` of `function(){}` in the jsterm does output "function ()"
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•