Closed Bug 1285100 Opened 8 years ago Closed 8 years ago

Pass WebGL2 conformance buffer-data-and-buffer-sub-data.html

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: ethlin, Assigned: ethlin)

References

(
URL
)

Details

Attachments

(2 files, 3 obsolete files)

turn InvalidValue when null
(deleted), patch
jgilbert
: review+
Details | Diff | Splinter Review
enable test (carry r+: pchang)
(deleted), patch
Details | Diff | Splinter Review
FAIL getError expected: INVALID_VALUE. Was NO_ERROR : calling bufferSubData when BufferDataSource is null should generate INVALID_VALUE FAIL getError expected: INVALID_VALUE. Was NO_ERROR : after evaluating: gl.bufferSubData(gl.ARRAY_BUFFER, 10, undefined)
Blocks: webgl2
Attached patch turn InvalidValue when null (deleted) — — Splinter Review
By spec, we should return InvalidValue when the returnData is null.
Attachment #8768636 - Flags: review?(jgilbert)
Attachment #8768636 - Flags: review?(jgilbert) → review+
Attached patch bug_1285100_2.patch (obsolete) (deleted) — — Splinter Review
Enable the conformance test.
Attachment #8773113 - Flags: review?(howareyou322)
Attachment #8773113 - Flags: review?(howareyou322) → review+
Keywords: checkin-needed
does not apply cleanly like: 1 out of 1 hunks FAILED -- saving rejects to file dom/canvas/test/webgl-conf/mochitest-errata.ini.rej
Flags: needinfo?(ethlin)
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/323b479bd91f Fix bufferSubData when the returnData is null. r=jgilbert
Backout by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e9e32ccc8cfb Backed out changeset 323b479bd91f for webgl issues
Attached patch enable test (carry r+: pchang) (obsolete) (deleted) — — Splinter Review
Rebase the patch to master.
Flags: needinfo?(ethlin)
Attachment #8773113 - Attachment is obsolete: true
Attached patch enable test (carry r+: pchang) (obsolete) (deleted) — — Splinter Review
The last patch was wrong. Correct it.
Attachment #8773177 - Attachment is obsolete: true
Comment on attachment 8773177 [details] [diff] [review] enable test (carry r+: pchang) Review of attachment 8773177 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/canvas/test/webgl-conf/mochitest-errata.ini @@ +152,5 @@ > [generated/test_2_conformance2__buffers__buffer-copying-restrictions.html] > fail-if = (os == 'mac') || (os == 'win') > [generated/test_2_conformance2__glsl3__forbidden-operators.html] > fail-if = (os == 'mac') || (os == 'win') > [generated/test_2_conformance__buffers__buffer-data-and-buffer-sub-data.html] Remove the test's section from the errata file if it has no errata left.
(In reply to Jeff Gilbert [:jgilbert] from comment #10) > Comment on attachment 8773177 [details] [diff] [review] > enable test (carry r+: pchang) > > Review of attachment 8773177 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: dom/canvas/test/webgl-conf/mochitest-errata.ini > @@ +152,5 @@ > > [generated/test_2_conformance2__buffers__buffer-copying-restrictions.html] > > fail-if = (os == 'mac') || (os == 'win') > > [generated/test_2_conformance2__glsl3__forbidden-operators.html] > > fail-if = (os == 'mac') || (os == 'win') > > [generated/test_2_conformance__buffers__buffer-data-and-buffer-sub-data.html] > > Remove the test's section from the errata file if it has no errata left. Okay!
Attached patch enable test (carry r+: pchang) (deleted) — — Splinter Review
Remove the test from mochitest-errata.ini.
Attachment #8773179 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b65b6c1811e5 Fix bufferSubData when the returnData is null. r=jgilbert https://hg.mozilla.org/integration/mozilla-inbound/rev/b3e155c83e23 Enable the webgl conformance test. r=pchang
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b65b6c1811e5 https://hg.mozilla.org/mozilla-central/rev/b3e155c83e23
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: