Closed Bug 1285156 Opened 8 years ago Closed 8 years ago

Too short interval of pressing OK key down and up will cause failed to open top sites' web page

Categories

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::Browser
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:2.6+, b2g-v2.6 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g 2.6+
Tracking Flags:
Tracking Status
b2g-v2.6 --- fixed

People

(Reporter: mlien, Assigned: danhuang)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

[gaia] danhuang1202:v2.6_1285156 > mozilla-b2g:v2.6
(deleted), text/x-github-pull-request
lchang
: review+
jocheng
: approval-gaia-v2.6+
Details
[Testing Steps] 1. Launch Browser app 2. Spatial navigation to any top site item 3. Press OK key down and up within a short interval [Expected result] Web page can be opened [Actual result] Failed to open web page [Build Info] Environment: 2.6 Nexus Player gaia: https://github.com/mozilla-b2g/gaia/commit/ace1cb9e420c432ade14f0829d33ca72c73ecc6c gecko: https://github.com/mozilla-b2g/gecko-b2g/commit/b7f962788a7fa3fc8e49a33a4b4e7799730a3937
Summary: Too short interval of pressing OK key down and up will cause failed to open web page → Too short interval of pressing OK key down and up will cause failed to open top sites' web page
Comment on attachment 8769576 [details] [gaia] danhuang1202:v2.6_1285156 > mozilla-b2g:v2.6 Please help review. This patch add keycode handler for displaying top-site by pressing OK button. Thanks.
Attachment #8769576 - Flags: review?(lchang)
Assignee: nobody → dhuang
Status: NEW → ASSIGNED
blocking-b2g: 2.6? → 2.6+
Comment on attachment 8769576 [details] [gaia] danhuang1202:v2.6_1285156 > mozilla-b2g:v2.6 The fix is a bit strange, but I'm fine with that if it works.
Attachment #8769576 - Flags: review?(lchang) → review+
Comment on attachment 8769576 [details] [gaia] danhuang1202:v2.6_1285156 > mozilla-b2g:v2.6 [Approval Request Comment] [Bug caused by] (feature/regressing bug #):TV 2.6 [User impact] if declined: quick click top-site wouldn't work [Testing completed]: Yes [Risk to taking this patch] (and alternatives if risky): None [String changes made]: None
Attachment #8769576 - Flags: approval-gaia-v2.6?
status-b2g-v2.6: --- → fixed
Comment on attachment 8769576 [details] [gaia] danhuang1202:v2.6_1285156 > mozilla-b2g:v2.6 Approve for TV 2.6
Attachment #8769576 - Flags: approval-gaia-v2.6? → approval-gaia-v2.6+
Merge in v2.6: https://github.com/mozilla-b2g/gaia/commit/a2ad61ba3ba848265fc10b13416e971effe212dd
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: