Closed Bug 1285181 (gdoc_pageend(22.85%)) Opened 8 years ago Closed 2 years ago

[perf][google suite][google docs] 22.85%(4,961 ms) slower than Chrome when opening 200+ pages mix content and to the page end

Categories

(Core :: JavaScript Engine, defect, P2)

50 Branch
x86
Linux
defect

Tracking

()

RESOLVED INCOMPLETE
Performance Impact none
Tracking Status
platform-rel --- -
firefox50 --- affected

People

(Reporter: cynthiatang, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: perf, Whiteboard: [platform-rel-Google][platform-rel-GoogleSuite][platform-rel-GoogleDocs])

# Test Case
STR
1. Launch the browser with blank page
2. Open the google doc with 200+ pages
3. Press ctrl+end (to the last page)
4. close the browser

# Hardware
OS: Ubuntu 14.04 LTS 64-bit
CPU: i7-3770 3.4GMhz
Memory: 16GB Ram
Hard Drive: 1TB SATA HDD
Graphics: GK107 [GeForce GT 640]/ GF108 [GeForce GT 440/630]

# Browsers
Firefox version: Nightly 50.0a1 (2016/06/28)
Chrome version: 50.0.2661.75

# Result
Browser | Run time (median value) 
Firefox | 21,711.11 ms
Chrome  | 26,672.22 ms

# Video
https://www.youtube.com/watch?v=LYBBG3c4ZFQ

# Profiler
https://cleopatra.io/#report=8112066661d2bb52e0501258969b7a651bca74b2

# Test Script:
https://github.com/Mozilla-TWQA/Hasal/blob/master/tests/test_firefox_gdoc_pageend.sikuli/test_firefox_gdoc_pageend.py
Mark as minor case, and marked wontfix in this iteration. Revisit here if necessary.

This bug fixing iteration will focus on critical bug 1264535, bug 1269666, bug 1269684, bug 1269690, bug 1269695, bug 1269698.
Severity: normal → minor
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Severity: minor → major
Status: RESOLVED → REOPENED
Priority: -- → P1
Resolution: WONTFIX → ---
Severity: major → critical
Flags: needinfo?(overholt)
Flags: needinfo?(kchen)
Flags: needinfo?(bugs)
Can you please provide a link to the test document used?

Not much in the profile to go on here ... :smaug likes using his profiler (the name of which I forget) so please needinfo him once you've provided the URL so he can reproduce locally.

Thanks!
Flags: needinfo?(overholt) → needinfo?(ctang)
Hi Andrew,
The test document's url is https://docs.google.com/document/d/1EPSmGqm2r4Qq42B4t1VOYacjTlL0JVuC8JSlUvoIhss/edit

Thanks!
Flags: needinfo?(ctang)
Olli, here is the test url[1]. Maybe you could find another info with your profiler.
Please check comment 2.

[1]
https://docs.google.com/document/d/1EPSmGqm2r4Qq42B4t1VOYacjTlL0JVuC8JSlUvoIhss/edit
Flags: needinfo?(bugs)
Page load time seems to be mostly JS, and then there is some reflow too, and page scroll looks the same. (I was using Zoom)
Would be good to get some JS engine dev to look at this. Perhaps jandem?
Flags: needinfo?(bugs)
Naveed can perhaps help.
Flags: needinfo?(bugs) → needinfo?(nihsanullah)
Am I reading the profiler output correct? Most of the time is spent in Content syscall inside PollWrapper?

There do appear to be a bunch of bailouts. Are those JIT bails?

Might be interesting comparing trace of Chrome to see where they spend time. Might give us areas that lend themselves to optimizations.
Flags: needinfo?(nihsanullah)
Flags: needinfo?(jdemooij)
Flags: needinfo?(efaustbmo)
Alias: gdoc_pageend(22.85%)
more finding on this issue?
Hannes maybe you can help profile this? I have a bunch of crashes to investigate.
Flags: needinfo?(jdemooij) → needinfo?(hv1989)
Could you clarify:

(In reply to Cynthia Tang [:cynthiatang] from comment #0)
> # Result
> Browser | Run time (median value) 
> Firefox | 21,711.11 ms
> Chrome  | 26,672.22 ms

Those numbers seem to be saying that Firefox is *faster*, not slower. Is that correct, or are the numbers reversed?
Flags: needinfo?(ctang)
Hi Steve,
Sorry, it's my fault. I just re-checked the result. It should be ...

Browser | Run time (median value) 
Chrome  | 21,711.11 ms
Firefox | 26,672.22 ms

Thank you.
Flags: needinfo?(ctang)
Steve, do we have update on this issue?
Flags: needinfo?(kchen) → needinfo?(sphink)
platform-rel: --- → ?
Whiteboard: [platform-rel-Google][platform-rel-GoogleDocs]
platform-rel: ? → -
Clearing myself. IIUC sfink and sstangl are looking into the google docs issues.
Flags: needinfo?(hv1989)
Whiteboard: [platform-rel-Google][platform-rel-GoogleDocs] → [platform-rel-Google][platform-rel-GoogleSuite][platform-rel-GoogleDocs]
Component: General → JavaScript Engine
Summary: [Perf][google docs] 22.85%(4,961 ms) slower than Chrome when opening 200+ pages mix content and to the page end → [perf][google suite][google docs] 22.85%(4,961 ms) slower than Chrome when opening 200+ pages mix content and to the page end
Whiteboard: [platform-rel-Google][platform-rel-GoogleSuite][platform-rel-GoogleDocs] → [qf:investigate][platform-rel-Google][platform-rel-GoogleSuite][platform-rel-GoogleDocs]
Keywords: perf
Flags: needinfo?(efaustbmo)
Nobody looked into these bugs for a while, moving to P2 and waiting for [qf] re-evaluation before moving back to P1.
Priority: P1 → P2
Whiteboard: [qf:investigate][platform-rel-Google][platform-rel-GoogleSuite][platform-rel-GoogleDocs] → [qf][platform-rel-Google][platform-rel-GoogleSuite][platform-rel-GoogleDocs]
[qf-] because opening 200+ tabs is not a typical use case.  Other blockers of bug 1260981 may be more relevant for qf.
Whiteboard: [qf][platform-rel-Google][platform-rel-GoogleSuite][platform-rel-GoogleDocs] → [qf-][platform-rel-Google][platform-rel-GoogleSuite][platform-rel-GoogleDocs]
QA Whiteboard: qa-not-actionable
Performance Impact: --- → -
Whiteboard: [qf-][platform-rel-Google][platform-rel-GoogleSuite][platform-rel-GoogleDocs] → [platform-rel-Google][platform-rel-GoogleSuite][platform-rel-GoogleDocs]

Clearing needinfo, this is stale and unactionable (the linked doc is gone).

Status: REOPENED → RESOLVED
Closed: 8 years ago2 years ago
Flags: needinfo?(sphink)
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.