Closed
Bug 1286190
Opened 8 years ago
Closed 8 years ago
[pine => mc] Kill MOZ_CIHLD_PERMISSIONS
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox50 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/63652/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63652/
Attachment #8770065 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•8 years ago
|
Attachment #8770065 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 2•8 years ago
|
||
Comment 3•8 years ago
|
||
Did you mean to cancel the review request?
Flags: needinfo?(lissyx+mozillians)
Assignee | ||
Comment 4•8 years ago
|
||
Yep, for now, I though bugzilla was synced with mozreview for this. There are some tests breakages we need to fix before.
Flags: needinfo?(lissyx+mozillians)
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8770065 [details]
Bug 1286190 - Get rid of MOZ_CHILD_PERMISSIONS
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63652/diff/1-2/
Attachment #8770065 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•8 years ago
|
Summary: Kill MOZ_CIHLD_PERMISSIONS → [pine => mc] Kill MOZ_CIHLD_PERMISSIONS
Assignee | ||
Comment 6•8 years ago
|
||
Sorry for the spam, I guess it is ready for review now, the failing tests were on dom/inputmethod which only really makes sense on B2G.
Flags: needinfo?(bzbarsky)
Comment 7•8 years ago
|
||
Comment on attachment 8770065 [details]
Bug 1286190 - Get rid of MOZ_CHILD_PERMISSIONS
https://reviewboard.mozilla.org/r/63652/#review61024
r=me, but we may need followup bugs to get rid of some of these now-always-returning-true "do we have this permission?" methods.
Attachment #8770065 -
Flags: review?(bzbarsky) → review+
Updated•8 years ago
|
Flags: needinfo?(bzbarsky)
Pushed by alissy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/11b0b0c47609
Get rid of MOZ_CHILD_PERMISSIONS r=bz
Assignee | ||
Comment 9•8 years ago
|
||
(In reply to Boris Zbarsky [:bz] from comment #7)
> Comment on attachment 8770065 [details]
> Bug 1286190 - Get rid of MOZ_CHILD_PERMISSIONS
>
> https://reviewboard.mozilla.org/r/63652/#review61024
>
> r=me, but we may need followup bugs to get rid of some of these
> now-always-returning-true "do we have this permission?" methods.
Sure, filed as a follow up: bug 1286592.
Comment 10•8 years ago
|
||
bugherder |
You need to log in
before you can comment on or make changes to this bug.
Description
•