Jason Laster [:jlast] Assignee
	Description • 8 years ago

The sourceMapURL is needed for client-side source map work. The goal is that the source actor form will include the source map's url so that the client can separately fetch the map.

	James Long (:jlongster)
	Comment 2 • 8 years ago

Comment on attachment 8770304 [details] [diff] [review]
sourceMapUrl.patch

Review of attachment 8770304 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! We should uplift this to beta. It's a harmless patch and will allow the new client to work on a few older versions of Firefox.

	Jason Laster [:jlast] Assignee
	Comment 3 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b4f145898118

	Jason Laster [:jlast] Assignee
	Comment 4 • 8 years ago

Comment on attachment 8770304 [details] [diff] [review]
sourceMapUrl.patch

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]:

	Jason Laster [:jlast] Assignee
	Comment 5 • 8 years ago

[Feature/regressing bug #]: 1286390
[User impact if declined]: Debugger clients will not be able to source map sources.
[Describe test coverage new/current, TreeHerder]: it doesn't need any new test coverage, we don't test form structures.
[Risks and why]: minimal, sourceMapURL is a source field.
[String/UUID change made/needed]: n/a

	Pulsebot
	Comment 6 • 8 years ago

Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/25d022b355be
Add sourceMapURL to source actor form. r=jlongster

	Carsten Book [:Tomcat]
	Comment 7 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/25d022b355be

	Sylvestre Ledru [:Sylvestre]
	Comment 8 • 8 years ago

Jason, can you tell me which bug introduced this issue?
> [Feature/regressing bug #]: 1286390
is incorrect.

	Jason Laster [:jlast] Assignee
	Comment 9 • 8 years ago

Hi Sylvestre, sorry for the confusion, this isn't a current issue but a feature we hope to add to support client-side source maps.

	Sylvestre Ledru [:Sylvestre]
	Comment 10 • 8 years ago

Thanks for the information.
Unfortunately, this is way too late for 48 as we are the end of the cycle.

	Gerry Chang [:gchang]
	Comment 11 • 8 years ago

Comment on attachment 8770304 [details] [diff] [review]
sourceMapUrl.patch

Review of attachment 8770304 [details] [diff] [review]:
-----------------------------------------------------------------

This patch adds support for Source Actor. Let's take it in 49 aurora.

	Ryan VanderMeulen [:RyanVM]
	Comment 12 • 8 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/cff908fa53dc