Closed
Bug 1286673
Opened 8 years ago
Closed 8 years ago
Test that sdk/event/dom.js does not leak windows
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(firefox49 fixed, firefox50 fixed)
RESOLVED
FIXED
mozilla50
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
Attachments
(1 file)
(deleted),
patch
|
gkrizsanits
:
review+
|
Details | Diff | Splinter Review |
Bug 1268898 fixed a window leak in sdk/event/dom.js. Lets add a test to verify that this doesn't regress again in the future.
I'm planning to use the test helpers I'm adding in bug 1267693.
Assignee | ||
Comment 1•8 years ago
|
||
Since sdk/event/dom.js cleans itself up on "DOMWindowClose" it was a bit hard to find a case that leaked. The best situation I could come up with is when the module is used on a window that is already closed.
This leaks without the fix from bug 1268898. It does not leak with the fix applied.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d908afda7a5
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8771042 [details] [diff] [review]
Test sdk/event/dom.js for leaks when used on a closed window. r=gabor
Try build looks good. This adds a test that catches the leak when we attach sdk/event/dom module to a closed window (fixed in bug 1268898).
Attachment #8771042 -
Flags: review?(gkrizsanits)
Updated•8 years ago
|
Attachment #8771042 -
Flags: review?(gkrizsanits) → review+
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/865803c7d5f8
Test sdk/event/dom.js for leaks when used on a closed window. r=gabor a=kwierso
Comment 4•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Comment 5•8 years ago
|
||
bugherder uplift |
status-firefox49:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•