Closed
Bug 1286892
Opened 8 years ago
Closed 8 years ago
Inspector sidebar tabs now have a bigger font-size
Categories
(DevTools :: Shared Components, defect, P1)
DevTools
Shared Components
Tracking
(firefox50+ verified)
People
(Reporter: ntim, Assigned: evanxd)
References
Details
(Keywords: regression, Whiteboard: [reserve-html])
Attachments
(3 files, 2 obsolete files)
No description provided.
Reporter | ||
Updated•8 years ago
|
Keywords: regression
Reporter | ||
Comment 1•8 years ago
|
||
Reporter | ||
Comment 2•8 years ago
|
||
Reporter | ||
Comment 3•8 years ago
|
||
[Tracking Requested - why for this release]: Visual regression
status-firefox50:
--- → affected
tracking-firefox50:
--- → ?
Updated•8 years ago
|
Blocks: devtools-html-2
Whiteboard: [devtools-html] [triage]
Updated•8 years ago
|
Flags: qe-verify+
Priority: -- → P3
QA Contact: alexandra.lucinet
Whiteboard: [devtools-html] [triage] → [reserve-html]
Assignee | ||
Comment 5•8 years ago
|
||
Current the font size is 12px[1]. Tracking code for the origin font size(before Bug 1259819).
[1]: https://github.com/mozilla/gecko-dev/blob/master/devtools/client/shared/components/tabs/tabs.css#L50-L58
Assignee: nobody → evan
Updated•8 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•8 years ago
|
||
Hi Tim,
Could you help to review the patch?
Thanks.
Attachment #8775523 -
Flags: review?(ntim.bugs)
Reporter | ||
Comment 7•8 years ago
|
||
Comment on attachment 8775523 [details] [diff] [review]
bug-1286892.patch
Review of attachment 8775523 [details] [diff] [review]:
-----------------------------------------------------------------
Can you remove the font size rule altogether ?
Attachment #8775523 -
Flags: review?(ntim.bugs)
Assignee | ||
Updated•8 years ago
|
Attachment #8775523 -
Attachment is obsolete: true
Assignee | ||
Comment 8•8 years ago
|
||
Hi Tim,
I updated the patch for your comments.
Please help to review the patch.
Thanks.
Attachment #8775863 -
Flags: review?(ntim.bugs)
Reporter | ||
Comment 9•8 years ago
|
||
Comment on attachment 8775863 [details] [diff] [review]
bug-1286892.patch
Review of attachment 8775863 [details] [diff] [review]:
-----------------------------------------------------------------
So, this needs rebasing because bug 1290003 landed (which fixed the font-size on OSX, but broke it on Windows).
Attachment #8775863 -
Flags: review?(ntim.bugs) → review+
Comment 10•8 years ago
|
||
Rebased it and landing today to make it for merge
Attachment #8775863 -
Attachment is obsolete: true
Attachment #8776103 -
Flags: review+
Comment 11•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/fa9e9291bfe34c20797978d5d6a8f4168bf961b8
Bug 1286892 - Set font size on tabs navigation as 11 px r=ntim
Comment 12•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Updated•8 years ago
|
Iteration: --- → 50.4 - Aug 1
Priority: P3 → P1
Assignee | ||
Comment 13•8 years ago
|
||
(In reply to Gabriel Luong [:gl] (ΦωΦ) from comment #10)
> Created attachment 8776103 [details]
> 1286892.patch
>
> Rebased it and landing today to make it for merge
Thanks for the rebase work, Gabriel.
Comment 14•8 years ago
|
||
Reproduced on Nightly 50.0a1 (2016-07-18), OS X 10.11.
Verified fixed FX 50.0a2 (2016-08-05).
Status: RESOLVED → VERIFIED
Updated•8 years ago
|
Flags: qe-verify+
Updated•8 years ago
|
Version: unspecified → Trunk
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•