Let's move other widgets to WidgetCache and use them in other widget code.

There's the patch, Thanks!

Comment on attachment 8771381 [details] [diff] [review] patch Review of attachment 8771381 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, just a few things: ::: widget/gtk/WidgetStyleCache.cpp @@ +168,5 @@ > > static GtkWidget* > +CreateFrameWidget() > +{ > + GtkWidget* widget = gtk_frame_new(NULL); Prefer nullptr. ::: widget/gtk/gtk3drawing.cpp @@ -972,5 @@ > - gtk_widget_set_direction(gHandleBoxWidget, direction); > - > - style = gtk_widget_get_style_context(gHandleBoxWidget); > - gtk_style_context_save(style); > - gtk_style_context_add_class(style, GTK_STYLE_CLASS_GRIP); It doesn't look like GTK adds this style class to the widget upon initialization, unlike GTK_STYLE_CLASS_TOOLBAR- should we be setting it? GTK 3.4 seems to check for it in gtkthemingengine.c, and sets it on a window's grip.

Good catch, Thanks. There's updated one with GRIPPER style set. It's also checked on 3.20 - we may convert it to CSS nodes later. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=40ccfa60ea9b

Comment on attachment 8771953 [details] [diff] [review] patch v.2 Review of attachment 8771953 [details] [diff] [review]: ----------------------------------------------------------------- Great, thanks!

Comment on attachment 8771953 [details] [diff] [review] patch v.2 Note: check-in a patch from Bug 1287082 before this one.

Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f4320d509686 Move Toolbar, Frame and Gripper widgets from gtk3drawing to WidgetCache, r=acomminos