Closed
Bug 1287243
Opened 8 years ago
Closed 8 years ago
Optimize the type used to store Variant's tag
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: Waldo, Assigned: Waldo)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
Variant<...Ts>::tag is a full size_t right now, even if sizeof...(Ts) is a very small number. When possible we should use smaller types that pack better and may be faster to get/set.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8771607 -
Flags: review?(nfitzgerald)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8771607 [details] [diff] [review]
Patch
Review of attachment 8771607 [details] [diff] [review]:
-----------------------------------------------------------------
Great, thanks :)
Attachment #8771607 -
Flags: review?(nfitzgerald) → review+
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2475145b53b6
Optimize the type used to store Variant's tag. r=fitzgen
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Blocks: 1362902
You need to log in
before you can comment on or make changes to this bug.
Description
•