Closed
Bug 1287464
Opened 8 years ago
Closed 8 years ago
Dotted focus outline is displayed around 'Visit MDN page' link
Categories
(DevTools :: Inspector: Rules, defect)
Tracking
(firefox47 unaffected, firefox48 unaffected, firefox49 unaffected, firefox50 affected)
RESOLVED
WONTFIX
Tracking | Status | |
---|---|---|
firefox47 | --- | unaffected |
firefox48 | --- | unaffected |
firefox49 | --- | unaffected |
firefox50 | --- | affected |
People
(Reporter: adalucinet, Unassigned)
References
Details
(Keywords: regression)
[Affected versions]:
- latest Nightly 50.0a1
[Affected platforms]:
- Ubuntu 16.04 64-bit
- Mac OS X 10.11.1
[Steps to reproduce]:
1. Launch Firefox
2. Open Inspector: Ctrl + Shift + C (for Ubuntu) or Cmd + Opt + C (for Mac OS X)
3. Right click on any property name via the Ruleview
4. Select 'Show MDN Docs' option from the context menu
5. Repeat steps 3 and 4
[Expected result]: 'Show MDN Docs' tooltip is properly displayed.
[Actual result]: A dotted focus outline is displayed around 'Visit MDN page' link.
[Regression range]:
- Last good revision: 9efa66f1c6a15449be7a3c37ade8e104ce2afef8
- First bad revision: 395c5a486954a3f747ceb07dfc8f1ebd3d00cf60
- Pushlog: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=9efa66f1c6a15449be7a3c37ade8e104ce2afef8&tochange=395c5a486954a3f747ceb07dfc8f1ebd3d00cf60
[Additional notes]:
- Screenshot: https://i.imgur.com/DKTYJ27.png
- Unable to reproduce under Windows 10 64-bit.
Reporter | ||
Updated•8 years ago
|
QA Whiteboard: [qe-dthtml]
Whiteboard: [devtools-html][triage]
Updated•8 years ago
|
Comment 1•8 years ago
|
||
The MDN docs popup takes the focus when opened. Before the migration to the HTML Tooltip, the content of the tooltip was wrapped in an iframe, and the focus was set to the body of the inner document of the iframe, without any visual indication for the user.
After the technical migration done in Bug 1259121, the tooltip content is no longer wrapped in an iframe, and the first focusable element is focused. In this case it is the <a> element "Visit MDN page".
Alternatively we could add set tabindex -1 on the tooltip container and modify the HTMLTooltip autofocus to allow the focus of any element with a tabindex attirbute. In this case the tooltip container would get the focus when the tooltip is opened, which is similar to the previous behaviour. However this will still result in an additional dotted border (this time around the container rather than around the link). But giving the user an indication of the current focus is actually an improvement over the previous situation, so I wouldn't change that.
marcoz: what do you think is the best for a popup/tooltip situation: focus a container, or directly focus an actionable element?
Flags: needinfo?(mzehe)
Comment 2•8 years ago
|
||
Definitely focus the actually actionable element, the link in this case, not the container.
Flags: needinfo?(mzehe)
Comment 3•8 years ago
|
||
Team discussed and decided to mark as 'wontfix'.
No longer blocks: devtools-html-1
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: qe-verify+
QA Contact: alexandra.lucinet
Resolution: --- → WONTFIX
Whiteboard: [devtools-html][triage]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•