Likely because of bug 1213517 :)

../../../../../workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:63:12: error: 'nsresult mozilla::MediaEngineGonkVideoSource::Allocate(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&, const nsACString_internal&)' marked override, but does not override ../../../../../workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:67:12: error: 'nsresult mozilla::MediaEngineGonkVideoSource::Deallocate()' marked override, but does not override ../../../../../workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:71:12: error: 'nsresult mozilla::MediaEngineGonkVideoSource::Restart(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&)' marked override, but does not override ../../../../../workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:117:10: error: 'size_t mozilla::MediaEngineGonkVideoSource::NumCapabilities()' marked override, but does not override ../../../../../workspace/gecko/dom/media/webrtc/MediaEngine.h:131:20: error: 'virtual nsresult mozilla::MediaEngineSource::Deallocate(mozilla::MediaEngineSource::BaseAllocationHandle*)' was hidden [-Werror=overloaded-virtual] ../../../../../workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:67:12: error: by 'nsresult mozilla::MediaEngineGonkVideoSource::Deallocate()' [-Werror=overloaded-virtual] ../../../../../workspace/gecko/dom/media/webrtc/MediaEngine.h:152:20: error: 'virtual nsresult mozilla::MediaEngineSource::Restart(mozilla::MediaEngineSource::BaseAllocationHandle*, const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&, const char**)' was hidden [-Werror=overloaded-virtual] ../../../../../workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:71:12: error: by 'nsresult mozilla::MediaEngineGonkVideoSource::Restart(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&)' [-Werror=overloaded-virtual] ../../../../../workspace/gecko/dom/media/webrtc/MediaEngine.h:189:20: error: 'virtual nsresult mozilla::MediaEngineSource::Allocate(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&, const nsACString_internal&, mozilla::MediaEngineSource::BaseAllocationHandle**, const char**)' was hidden [-Werror=overloaded-virtual] ../../../../../workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:63:12: error: by 'nsresult mozilla::MediaEngineGonkVideoSource::Allocate(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&, const nsACString_internal&)' [-Werror=overloaded-virtual] ../../../../../workspace/gecko/dom/media/webrtc/MediaEngineCameraVideoSource.h:88:18: error: 'virtual size_t mozilla::MediaEngineCameraVideoSource::NumCapabilities() const' was hidden [-Werror=overloaded-virtual] ../../../../../workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:117:10: error: by 'size_t mozilla::MediaEngineGonkVideoSource::NumCapabilities()' [-Werror=overloaded-virtual] ../../../../../workspace/gecko/dom/media/webrtc/MediaEngineWebRTC.cpp:175:49: error: invalid new-expression of abstract class type 'mozilla::MediaEngineGonkVideoSource' make[6]: *** [MediaEngineWebRTC.o] Error 1 make[6]: *** Waiting for unfinished jobs.... /home/worker/workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:63:12: error: 'nsresult mozilla::MediaEngineGonkVideoSource::Allocate(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&, const nsACString_internal&)' marked override, but does not override /home/worker/workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:67:12: error: 'nsresult mozilla::MediaEngineGonkVideoSource::Deallocate()' marked override, but does not override /home/worker/workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:71:12: error: 'nsresult mozilla::MediaEngineGonkVideoSource::Restart(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&)' marked override, but does not override /home/worker/workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:117:10: error: 'size_t mozilla::MediaEngineGonkVideoSource::NumCapabilities()' marked override, but does not override /home/worker/workspace/gecko/dom/media/webrtc/MediaEngine.h:131:20: error: 'virtual nsresult mozilla::MediaEngineSource::Deallocate(mozilla::MediaEngineSource::BaseAllocationHandle*)' was hidden [-Werror=overloaded-virtual] /home/worker/workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:67:12: error: by 'nsresult mozilla::MediaEngineGonkVideoSource::Deallocate()' [-Werror=overloaded-virtual] /home/worker/workspace/gecko/dom/media/webrtc/MediaEngine.h:152:20: error: 'virtual nsresult mozilla::MediaEngineSource::Restart(mozilla::MediaEngineSource::BaseAllocationHandle*, const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&, const char**)' was hidden [-Werror=overloaded-virtual] /home/worker/workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:71:12: error: by 'nsresult mozilla::MediaEngineGonkVideoSource::Restart(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&)' [-Werror=overloaded-virtual] /home/worker/workspace/gecko/dom/media/webrtc/MediaEngine.h:189:20: error: 'virtual nsresult mozilla::MediaEngineSource::Allocate(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&, const nsACString_internal&, mozilla::MediaEngineSource::BaseAllocationHandle**, const char**)' was hidden [-Werror=overloaded-virtual] /home/worker/workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:63:12: error: by 'nsresult mozilla::MediaEngineGonkVideoSource::Allocate(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&, const nsACString_internal&)' [-Werror=overloaded-virtual] /home/worker/workspace/gecko/dom/media/webrtc/MediaEngineCameraVideoSource.cpp:42:1: error: 'virtual size_t mozilla::MediaEngineCameraVideoSource::NumCapabilities() const' was hidden [-Werror=overloaded-virtual] /home/worker/workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.h:117:10: error: by 'size_t mozilla::MediaEngineGonkVideoSource::NumCapabilities()' [-Werror=overloaded-virtual] /home/worker/workspace/gecko/dom/media/webrtc/MediaEngineGonkVideoSource.cpp:159:53: error: no matching function for call to 'mozilla::MediaEngineGonkVideoSource::ChooseCapability(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&)' make[6]: *** [Unified_cpp_dom_media_webrtc0.o] Error 1 make[5]: *** [dom/media/webrtc/target] Error 2 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [compile] Error 2 make[3]: *** [default] Error 2 make[2]: *** [realbuild] Error 2 make[1]: *** [build] Error 2 make: *** [out/target/product/aries/obj/DATA/gecko_intermediates/gecko] Error 2

Review commit: https://reviewboard.mozilla.org/r/65272/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/65272/

This will require more work: /home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/webrtc/MediaEngineGonkVideoSource.cpp: In member function 'virtual nsresult mozilla::MediaEngineGonkVideoSource::Allocate(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&, const nsACString_internal&, mozilla::MediaEngineSource::BaseAllocationHandle**, const char**)': /home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/webrtc/MediaEngineGonkVideoSource.cpp:161:53: error: no matching function for call to 'mozilla::MediaEngineGonkVideoSource::ChooseCapability(const mozilla::dom::MediaTrackConstraints&, const mozilla::MediaEnginePrefs&, const nsString&)' ChooseCapability(aConstraints, aPrefs, aDeviceId); ^ /home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/webrtc/MediaEngineGonkVideoSource.cpp:161:53: note: candidate is: In file included from Unified_cpp_dom_media_webrtc0.cpp:11:0: /home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/webrtc/MediaEngineCameraVideoSource.cpp:207:1: note: virtual bool mozilla::MediaEngineCameraVideoSource::ChooseCapability(const mozilla::NormalizedConstraints&, const mozilla::MediaEnginePrefs&, const nsString&) MediaEngineCameraVideoSource::ChooseCapability( ^ /home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/webrtc/MediaEngineCameraVideoSource.cpp:207:1: note: no known conversion for argument 1 from 'const mozilla::dom::MediaTrackConstraints' to 'const mozilla::NormalizedConstraints&' In file included from Unified_cpp_dom_media_webrtc0.cpp:29:0: /home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/webrtc/MediaEngineGonkVideoSource.cpp: In member function 'virtual void mozilla::MediaEngineGonkVideoSource::Shutdown()': /home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/webrtc/MediaEngineGonkVideoSource.cpp:392:16: error: no matching function for call to 'mozilla::MediaEngineGonkVideoSource::Deallocate()' Deallocate(); ^ /home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/webrtc/MediaEngineGonkVideoSource.cpp:392:16: note: candidate is: /home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/webrtc/MediaEngineGonkVideoSource.cpp:175:1: note: virtual nsresult mozilla::MediaEngineGonkVideoSource::Deallocate(mozilla::MediaEngineSource::BaseAllocationHandle*) MediaEngineGonkVideoSource::Deallocate(BaseAllocationHandle* aHandle) ^ /home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/webrtc/MediaEngineGonkVideoSource.cpp:175:1: note: candidate expects 1 argument, 0 provided

Comment on attachment 8772474 [details] Bug 1287854 - Fix MediaEngineGonk build Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65272/diff/1-2/

I'll probably use that bug just to fix build time and file a follow up to perform the proper upgrade of that code.

Comment on attachment 8772474 [details] Bug 1287854 - Fix MediaEngineGonk build Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65272/diff/2-3/

Comment on attachment 8772474 [details] Bug 1287854 - Fix MediaEngineGonk build https://reviewboard.mozilla.org/r/65272/#review62868

Pushed by alissy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/91056939fa77 Fix MediaEngineGonk build r=padenot