Closed
Bug 1288033
Opened 8 years ago
Closed 8 years ago
Decease the busyCount when Cancel() is called in WorkerRunnable.
Categories
(Core :: DOM: Workers, defect)
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
Details
Attachments
(1 file)
|
(deleted),
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
We leak a busyCount value when Cancel() is called.
Attachment #8772730 -
Flags: review?(khuey)
Comment on attachment 8772730 [details] [diff] [review]
cancel_runnable.patch
Review of attachment 8772730 [details] [diff] [review]:
-----------------------------------------------------------------
Ah, this is a good catch.
Attachment #8772730 -
Flags: review?(khuey) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/512f176d3de6
Decease the busyCount when Cancel() is called in WorkerRunnable, r=khuey
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/90c6741cda5d
part 2 - fixed a compilation error, r=me
|
||
Comment 4•8 years ago
|
||
Hi baku, have backed this out due to W-e10s failures, e.g. https://treeherder.mozilla.org/logviewer.html#?job_id=32331215&repo=mozilla-inbound#L4263
Flags: needinfo?(amarchesini)
Backout by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1de4835bc141
Backed out changeset 90c6741cda5d for web platform e10s failure
|
||
Comment 6•8 years ago
|
||
seems iris missed the first commit from comment #2 when doing the backout so to fix a bustage i backed that out too
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/008ef774d48e
Backed out changeset 512f176d3de6 to fix a incomplete backout
|
Assignee | |
Updated•8 years ago
|
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e7371939dd6
Decease the busyCount when Cancel() is called in WorkerRunnable, r=khuey
|
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•