Closed Bug 1288283 Opened 8 years ago Closed 8 years ago

Stylo: Implement property glue to connect properties already implemented in Servo

Categories

(Core :: CSS Parsing and Computation, defect, P1)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: cpeterson, Assigned: manishearth)

References

Details

(Whiteboard: [stylo:m2])

Manish wrote: In terms of property types to look at, from quickly going through the spreadsheet and nsStyleStruct.h: * nsCSSShadowArray (for text-shadow and box-shadow) * things that store nsStrings (text-emphasis-style, quotes, will-change, …) * transform, which uses an nsCSSValueSharedList (refcounted list of CSS specified values containing the transform functions) – these are shared between the style rules and the computed values just to avoid cloning them and since a different representation isn’t needed, though I’m not sure I’d bother trying to stash an nsCSSValueSharedList on the Servo specified value to share later. (Still need to bug dbaron about bug 1262357 here.) * other nsIURI-taking properties, like marker-mid, which will be similar but not exactly the same as the URLValue support (though this will change a little in bug 652991) * maybe nsStyleClipPath/nsStyleBasicShape (for clip-path) * and maybe nsStyleFilter (for filter) * Calc and URL are part of the property glue
All of these are supported now, except for will-change, which has a pull request in https://github.com/servo/servo/pull/15813
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.