Closed
Bug 1288444
Opened 8 years ago
Closed 5 years ago
Add categorical histograms to the longitudinal dataset
Categories
(Data Platform and Tools Graveyard :: Datasets: Longitudinal, defect, P3)
Data Platform and Tools Graveyard
Datasets: Longitudinal
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: gfritzsche, Unassigned)
References
Details
From IRC:
> categorical histograms could be stored in structs which is what we are already doing in main_summary:
> https://github.com/mozilla/telemetry-batch-view/blob/master/src/main/scala/com/mozilla/telemetry/views/MainSummaryView.scala#L387
> Probably using maps is the better choice as it allows to use cross join unnest
Updated•8 years ago
|
Points: --- → 3
Priority: -- → P2
Updated•8 years ago
|
Priority: P2 → P3
Summary: Make categorical histograms convenient in longitudinal dataset & re:dash → Add categorical histograms to the longitudinal dataset
Updated•8 years ago
|
Assignee: nobody → rharter
Updated•8 years ago
|
Priority: P3 → P2
Updated•8 years ago
|
Priority: P2 → P1
Comment 1•8 years ago
|
||
I need some clarification on this. The histograms.json [0] file only lists two example categorical histograms. Are there histograms missing from this set or are we expecting more in the future? Is there an easy way to enumerate these besides filtering past pings?
[0] https://hg.mozilla.org/releases/mozilla-release/raw-file/tip/toolkit/components/telemetry/Histograms.json
Flags: needinfo?(gfritzsche)
Reporter | ||
Comment 2•8 years ago
|
||
(In reply to Ryan Harter [:harter] from comment #1)
> I need some clarification on this. The histograms.json [0] file only lists
> two example categorical histograms. Are there histograms missing from this
> set or are we expecting more in the future? Is there an easy way to
> enumerate these besides filtering past pings?
We are expecting more in the future. AFAIU the plan is that once the tooling is in place, data collection reviewers can point engineers to using them.
Flags: needinfo?(gfritzsche)
Reporter | ||
Comment 3•8 years ago
|
||
(In reply to Ryan Harter [:harter] from comment #1)
> Is there an easy way to enumerate these besides filtering past pings?
Not right now, although i'm thinking about how to fix this.
Comment 4•8 years ago
|
||
I tried to find some example pings from the test histograms, but they don't
seem to be reporting [0].
Do we have examples or a spec for these histograms payloads? The docs
mention these will be like enumerated histograms with labels, but the format's
still unclear to me. Will they payload be an array, as in a enumerated
histogram, or a map? Thanks!
[0] https://gist.github.com/harterrt/ed44bdd4e07b75be652154f5d706eef6
Flags: needinfo?(gfritzsche)
Reporter | ||
Comment 5•8 years ago
|
||
(In reply to Ryan Harter [:harter] from comment #4)
> Will they payload be an array, as in a enumerated
> histogram, or a map? Thanks!
Yes, in the payload they are just like enumerated histograms.
The labels are only used in the client API, internally it is just like an enumerated histogram.
E.g. for TELEMETRY_TEST_CATEGORICAL, adding 1 to the labels "CommonLabel" & "Label2", <ping>/payload/histograms/TELEMETRY_TEST_CATEGORICAL looks like this:
> {"range":[1,3],"bucket_count":4,"histogram_type":1,"values":{"0":1,"1":1,"2":0},"sum":1}
Flags: needinfo?(gfritzsche)
Reporter | ||
Comment 6•8 years ago
|
||
Note that we are changing the bucket logic in bug 1312806 to reduce user error.
Bug 1324478 was filed to deal with this from telemetry-batch-view.
Updated•8 years ago
|
Priority: P1 → P2
Updated•8 years ago
|
Priority: P2 → P3
Comment 7•8 years ago
|
||
Moving to P3. I do not plan on addressing this in Q2.
Comment 8•7 years ago
|
||
Moving to P2, due to Bug 1376596
Component: Metrics: Pipeline → Datasets: Longitudinal
Priority: P3 → P2
Product: Cloud Services → Data Platform and Tools
Comment 10•7 years ago
|
||
I will not be able to take care of this in the next month. Moving to P3.
Priority: P2 → P3
Updated•7 years ago
|
Assignee: rharter → nobody
Comment 11•5 years ago
|
||
Longitudinal has been decommissioned per Bug 1572033.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
Updated•5 years ago
|
Product: Data Platform and Tools → Data Platform and Tools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•