Closed
Bug 1288696
Opened 8 years ago
Closed 8 years ago
Move MenuSeparatorWidget to WidgetCache
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: stransky, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
acomminos
:
review+
|
Details | Diff | Splinter Review |
Let's move other widgets to WidgetCache and use them in other widget code.
|
Reporter | |
Comment 1•8 years ago
|
||
This patch moves menu separator to WidgetCache. We can implement gtk3.20 css node style for Bug 1266914.
Try: ttps://treeherder.mozilla.org/#/jobs?repo=try&revision=25e43158023f
Attachment #8774306 -
Flags: review?(andrew)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8774306 [details] [diff] [review]
patch
Review of attachment 8774306 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good!
Attachment #8774306 -
Flags: review?(andrew) → review+
|
|
Reporter | |
Comment 3•8 years ago
|
||
Comment on attachment 8774306 [details] [diff] [review]
patch
Thanks!
Note: It needs Bug 1288412 land prior this one.
|
|
Reporter | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f5b78b3d918
Move MenuSeparatorWidget to WidgetCache, r=acomminos
Keywords: checkin-needed
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•