Closed Bug 1288835 Opened 8 years ago Closed 8 years ago

Usage of dummyElement in rules.js causes either "can't access dead object" exceptions or leaks

Categories

(DevTools :: Inspector, defect, P2)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1265796

People

(Reporter: erahm, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

WIP - Workaround dummy element weirdness
(deleted), patch
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #1276366 +++

rules.js holds a reference to a dummyElement in frame that it immediately destroys. The changes in bug 1276366 cause this dummyElement to get destroyed after the frame is removed [1].

I have an attempted work around, but this leads to some window leaks, ie:

> devtools/client/framework/test/browser_toolbox_hosts.js | leaked 2 window(s) until shutdown [url = data:text/html,<html></html>]

[1] https://dxr.mozilla.org/mozilla-central/rev/4c05938a64a7fde3ac2d7f4493aee1c5f2ad8a0a/devtools/client/inspector/rules/rules.js#130-134
This was my attempted fix, it should at least highlight the issue.
I think the issue with this approach is that the code calling the createDummyDocument() can be called several times in the lifecycle of rules.js but destroy() will only be called once, only removing the last frame created.

Will take a look at this. Inspector bug triage, filter on CLIMBING SHOES.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: -- → P2
This code is being removed in bug 1265796.
Blocking on Bug 1265796, unassigning.
Assignee: jdescottes → nobody
Status: ASSIGNED → NEW
Depends on: 1265796
We removed the dummy document in bug 1265796.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: