Now that we've dropped support for VS2013 (bug 1186064), we can use VS2015's __func__ instead of our polyfill.

Comment on attachment 8774071 [details] [diff] [review] remove-__func__-polyfill.patch Review of attachment 8774071 [details] [diff] [review]: ----------------------------------------------------------------- Want to take care of http://dxr.mozilla.org/mozilla-central/source/media/libcubeb/tests/test_sanity.cpp#21 while you're at it?

Thanks for the speedy review, Nathan! (In reply to Nathan Froyd [:froydnj] from comment #1) > Want to take care of > http://dxr.mozilla.org/mozilla-central/source/media/libcubeb/tests/ > test_sanity.cpp#21 while you're at it? @ kinetik: mozilla-central no longer supports VS2013. Since you maintain cubeb as an external library, do you wish to maintain VS2013 support for other applications that may use cubeb? https://github.com/kinetiknz/cubeb/blob/master/test/test_sanity.cpp#L21

(In reply to Chris Peterson [:cpeterson] from comment #2) > @ kinetik: mozilla-central no longer supports VS2013. Since you maintain > cubeb as an external library, do you wish to maintain VS2013 support for > other applications that may use cubeb? > > https://github.com/kinetiknz/cubeb/blob/master/test/test_sanity.cpp#L21 Nope, so I've killed this upstream in https://github.com/kinetiknz/cubeb/commit/a966fafbf7f95c6d516b444f15eed1648c8e6dc8

(In reply to Matthew Gregan [:kinetik] from comment #3) > Nope, so I've killed this upstream in > https://github.com/kinetiknz/cubeb/commit/ > a966fafbf7f95c6d516b444f15eed1648c8e6dc8 Thanks!

Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/19920a6cf0f8 Remove __func__ polyfill for VS2013. r=froydnj