Julian Descottes [:jdescottes] Assignee
	Description • 8 years ago

Regression from Bug 1262439. 

Have a look at the GIF in attachment and pay attention to the color of the text below the magnifying glass.

It changes depending on the currently edited color.

STRs:
- open inspector > ruleview
- create property color: lightgrey 
- open colorpicker
- click on eyedropper icon
- move the mouse on the content page

ER: The text containing the color HEX code should be readible.
AR: The text containing the color HEX is in "lightgrey" and is hard to read.

	Julian Descottes [:jdescottes] Assignee
	Comment 1 • 8 years ago

Looks like this only happens on about:home.

On a sidenote the new eyedropper crashes on several other about: pages such as :
- about:preferences
- about:tabcrashed
- about:config

	Julian Descottes [:jdescottes] Assignee
	Comment 2 • 8 years ago

Actually this happens on any page, when you change the "color" value of the HTML element in the ruleview.

STRs:
- open inspector > ruleview
- add a new rule for the selector "html" 
- create property color: lightgrey 
- open colorpicker
- click on eyedropper icon
- move the mouse on the content page

	Julian Descottes [:jdescottes] Assignee
	Comment 3 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/69292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69292/

	Julian Descottes [:jdescottes] Assignee
	Comment 4 • 8 years ago

Inspector bug triage, filter on CLIMBING SHOES.

Regression, but not triggered too frequently and non blocking-> P3.

	Julian Descottes [:jdescottes] Assignee
	Comment 6 • 8 years ago

Turns out the selector used to reset highlighter styles was too generic and could impact the content page elements (see Bug 1291306).

Moved the color reset to ":-moz-native-anonymous .eye-dropper-root"

	Matteo Ferretti [:zer0] [:matteo]
	Comment 7 • 8 years ago

(In reply to Julian Descottes [:jdescottes] from comment #6)
> Turns out the selector used to reset highlighter styles was too generic and
> could impact the content page elements (see Bug 1291306).

That's true, but why you moved? I think that having also the `color: initial` under `:-moz-native-anonymous .highlighter-container` is safe enough; and could be prevent similar bug on other highlighters. Is there a specific reason why you moved outside those rules set?

	Julian Descottes [:jdescottes] Assignee
	Comment 9 • 8 years ago

(In reply to Matteo Ferretti [:zer0] [:matteo] from comment #7)
> (In reply to Julian Descottes [:jdescottes] from comment #6)
> > Turns out the selector used to reset highlighter styles was too generic and
> > could impact the content page elements (see Bug 1291306).
> 
> That's true, but why you moved? I think that having also the `color:
> initial` under `:-moz-native-anonymous .highlighter-container` is safe
> enough; and could be prevent similar bug on other highlighters. Is there a
> specific reason why you moved outside those rules set?

Good point! I wrongly assumed highlighter-container was not set for the eye-dropper highlighter container. Updated the patch.

	Matteo Ferretti [:zer0] [:matteo]
	Comment 10 • 8 years ago
mozreview-review

Comment on attachment 8777831 [details]
Bug 1289150 - prevent HTML element style color to impact highlighters;

https://reviewboard.mozilla.org/r/69292/#review67194

	Matteo Ferretti [:zer0] [:matteo]
	Comment 11 • 8 years ago

Thanks, Julian!

	Pulsebot
	Comment 12 • 8 years ago

Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/04ecf84edcb0
prevent HTML element style color to impact highlighters;r=zer0

	Carsten Book [:Tomcat]
	Comment 13 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/04ecf84edcb0

	Md. Rahimul Islam
	Comment 14 • 8 years ago

I have successfully reproduce this bug on firefox nightly 50.0a1 (2016-07-25)
with windows 7 (32 bit)
Mozilla/5.0 (Windows NT 6.1; rv:50.0) Gecko/20100101 Firefox/50.0

I found this fix on latest nightly 51.0a1 (2016-08-09)

Mozilla/5.0 (Windows NT 6.1; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID : 20160809030200

[bugday-20160810]