Closed Bug 1289860 Opened 8 years ago Closed 8 years ago

Consider storing change hints from parallel traversal somewhere other than the style context

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bholley, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We need to batch up change hints generated during parallel traversal such that we can pass them to layout on the main thread. Right now we stash them on the style context and find them later during traversal. This is suboptimal, because it imposes a permanent memory cost for a very ephemeral piece of data.

Emilio suggested writing them into a Rust channel. This would work as long as the change hints don't need to be processed in order, but they might in fact need to be.
Blocks: stylo-perf
No longer blocks: stylo
The other day we were wondering how many change hints typically get generated per style flush.  Here are some numbers from a short browsing session.
We store this now in the node restyle data, so I think we can close this.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: