Closed
Bug 1290018
Opened 8 years ago
Closed 8 years ago
[WebGL2] pass gl.getInternalformatParameter() in gl-object-get-calls.html
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: jerry, Assigned: jerry)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
getInternalformatParameter() should return invalid enum with DEPTH_STENCIL.
gles spec 3.0.4 p212
An internal format is depth-renderable if it is one of the formats from table 3.14. No other formats are depth-renderable.
In table 3.14 (p133), DEPTH_STENCIL is not in that table.
|
Assignee | |
Comment 1•8 years ago
|
||
Sorry, comment 0 is incorrect.
In webgl2 spec:
void renderbufferStorage(GLenum target, GLenum internalformat, GLsizei width, GLsizei height) (OpenGL ES 3.0.4 §4.4.2, man page)
Accepts internal formats from OpenGL ES 3.0 as detailed in the specification and man page.
To be backward compatible with WebGL 1, also accepts internal format DEPTH_STENCIL, which should be mapped to DEPTH24_STENCIL8 by implementations.
So the DEPTH_STENCIL is valid.
Please check Bug 1241702.
|
|
Assignee | |
Comment 2•8 years ago
|
||
Try to update the test
https://github.com/KhronosGroup/WebGL/pull/1945
|
|
Assignee | |
Comment 3•8 years ago
|
||
Is my understanding correct for comment 1?
Flags: needinfo?(jgilbert)
|
||
Comment 4•8 years ago
|
||
(In reply to Jerry Shih[:jerry] (UTC+8) from comment #3)
> Is my understanding correct for comment 1?
Yes though technically I don't think this exception necessarily applies to getInternalformatParameter.
It should though.
Flags: needinfo?(jgilbert)
|
|
Assignee | |
Comment 5•8 years ago
|
||
Add DEPTH_STENCIL to depth-renderable list.
https://github.com/KhronosGroup/WebGL/pull/1945
Just pick that change.
Attachment #8775830 -
Flags: review?(jgilbert)
|
|
||
Updated•8 years ago
|
Attachment #8775830 -
Flags: review?(jgilbert) → review+
|
|
Assignee | |
Comment 6•8 years ago
|
||
cherry-pick webgl conformance patch.
Please the attachment 8775830 [details] [diff] [review] to m-c.
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/22b93575a3d9
update webgl conformance tests. r=jgilbert
Keywords: checkin-needed
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•