Closed Bug 1290201 Opened 8 years ago Closed 8 years ago

Windows build bustage due to clobber failure on last_log.json

Categories

(Firefox Build System :: General, defect)

Unspecified
Windows
defect
Not set
normal

Tracking

(firefox51 fixed)

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: RyanVM, Assigned: gps)

References

Details

Attachments

(1 file)

After updating to m-c tip today and trying to build, I hit the bustage below. 0:00.76 c:\mozilla-build\mozmake\mozmake.EXE -f client.mk -s 0:15.37 Automatically clobbering c:\Users\Ryan\repos\mozilla-central\objdir-fx-64 0:15.37 rmtree() failed for "('c:\\Users\\Ryan\\repos\\mozilla-central\\objdir-fx-64',)". Reason: The process cannot access the file because it is being used by another process (13). Retrying... 0:15.37 rmtree() failed for "('c:\\Users\\Ryan\\repos\\mozilla-central\\objdir-fx-64',)". Reason: The process cannot access the file because it is being used by another process (13). Retrying... 0:15.37 rmtree() failed for "('c:\\Users\\Ryan\\repos\\mozilla-central\\objdir-fx-64',)". Reason: The process cannot access the file because it is being used by another process (13). Retrying... 0:15.37 rmtree() failed for "('c:\\Users\\Ryan\\repos\\mozilla-central\\objdir-fx-64',)". Reason: The process cannot access the file because it is being used by another process (13). Retrying... 0:15.37 rmtree() failed for "('c:\\Users\\Ryan\\repos\\mozilla-central\\objdir-fx-64',)". Reason: The process cannot access the file because it is being used by another process (13). Retrying... 0:15.38 Traceback (most recent call last): 0:15.38 File "c:/Users/Ryan/repos/mozilla-central/config/pythonpath.py", line 56, in <module> 0:15.38 main(sys.argv[1:]) 0:15.38 File "c:/Users/Ryan/repos/mozilla-central/config/pythonpath.py", line 48, in main 0:15.38 execfile(script, frozenglobals) 0:15.38 File "c:/Users/Ryan/repos/mozilla-central/python/mozbuild/mozbuild/controller/clobber.py", line 196, in <module> 0:15.38 sys.exit(main(sys.argv[1:], os.environ, os.getcwd(), sys.stdout)) 0:15.38 File "c:/Users/Ryan/repos/mozilla-central/python/mozbuild/mozbuild/controller/clobber.py", line 184, in main 0:15.38 required, performed, message = clobber.maybe_do_clobber(cwd, auto, fh) 0:15.38 File "c:/Users/Ryan/repos/mozilla-central/python/mozbuild/mozbuild/controller/clobber.py", line 153, in maybe_do_clobber 0:15.38 rmtree(self.topobjdir) 0:15.39 File "c:\Users\Ryan\repos\mozilla-central\testing\mozbase\mozfile\mozfile\mozfile.py", line 137, in rmtree 0:15.39 return remove(dir) 0:15.39 File "c:\Users\Ryan\repos\mozilla-central\testing\mozbase\mozfile\mozfile\mozfile.py", line 234, in remove 0:15.39 _call_with_windows_retry(shutil.rmtree, (path,)) 0:15.39 File "c:\Users\Ryan\repos\mozilla-central\testing\mozbase\mozfile\mozfile\mozfile.py", line 193, in _call_with_windows_retry 0:15.39 _call_windows_retry(*args, **kwargs) 0:15.39 File "c:\Users\Ryan\repos\mozilla-central\testing\mozbase\mozfile\mozfile\mozfile.py", line 151, in _call_windows_retry 0:15.40 func(*args) 0:15.40 File "c:\mozilla-build\python\lib\shutil.py", line 247, in rmtree 0:15.40 rmtree(fullname, ignore_errors, onerror) 0:15.40 File "c:\mozilla-build\python\lib\shutil.py", line 252, in rmtree 0:15.40 onerror(os.remove, fullname, sys.exc_info()) 0:15.40 File "c:\mozilla-build\python\lib\shutil.py", line 250, in rmtree 0:15.40 os.remove(fullname) 0:15.40 WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'c:\\Users\\Ryan\\repos\\mozilla-central\\objdir-fx-64\\.mozbuild\\last_log.json' 0:15.41 client.mk:344: recipe for target 'c:/Users/Ryan/repos/mozilla-central/objdir-fx-64/CLOBBER' failed 0:15.41 mozmake.EXE: *** [c:/Users/Ryan/repos/mozilla-central/objdir-fx-64/CLOBBER] Error 1 I was able to build successfully after manually running |./mach clobber|.
As I just wrote in bug 1195748, this also explains a scenario where the log may not be there at the end of the build on Linux and Mac. I think the reasonable thing to do here is to exclude the file from clobbering.
And excluding files from clobbering is related to bug 974281 (Visual Studio IDE files). The patch in that bug supports a set of paths to not clobber. I should land that bug and we can extend the "no clobber" list.
I'll get bug 974281 landed, then we can make an exception for log files.
Depends on: 974281
This is still happening, and bug 974281 doesn't seem to have gotten any traction in a few weeks.
Is there something we can back out to get this working again? This is the 3rd time in the past month or so that my Windows builds have gone broken in some way. It's hard to get traction because so few people are building on Windows.
Flags: needinfo?(gps)
Disable autoclobber and clobber manually when you're asked to.
What glandium said. I'm waiting for a re-review on bug 974281. Hopefully ted will get to it soon.
Flags: needinfo?(gps)
Sorry, I think I forgot to re-mark r+ since it was already marked r+...
I'll code up a patch real quick.
Assignee: nobody → gps
Status: NEW → ASSIGNED
Summary: Windows build bustage due to clobber failure → Windows build bustage due to clobber failure on last_log.json
Comment on attachment 8783002 [details] Bug 1290201 - Don't clobber .mozbuild directory by default; https://reviewboard.mozilla.org/r/73000/#review70798
Attachment #8783002 - Flags: review?(ted) → review+
Pushed by gszorc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/43ed93524911 Don't clobber .mozbuild directory by default; r=ted
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
This is not fixed. $ mach build 0:04.92 c:\mozilla-build\mozmake\mozmake.EXE -f client.mk -s 0:55.14 Automatically clobbering f:\m\mozilla-unified\obj-x86_64-pc-mingw32 0:55.14 rmtree() failed for "('f:\\m\\mozilla-unified\\obj-x86_64-pc-mingw32',)". Reason: プロセスはファイルにアクセスできません。別のプロセスが使用中です。 (13). Retrying... 0:55.14 rmtree() failed for "('f:\\m\\mozilla-unified\\obj-x86_64-pc-mingw32',)". Reason: プロセスはファイルにアクセスできません。別のプロセスが使用中です。 (13). Retrying... 0:55.14 rmtree() failed for "('f:\\m\\mozilla-unified\\obj-x86_64-pc-mingw32',)". Reason: プロセスはファイルにアクセスできません。別のプロセスが使用中です。 (13). Retrying... 0:55.14 rmtree() failed for "('f:\\m\\mozilla-unified\\obj-x86_64-pc-mingw32',)". Reason: プロセスはファイルにアクセスできません。別のプロセスが使用中です。 (13). Retrying... 0:55.14 rmtree() failed for "('f:\\m\\mozilla-unified\\obj-x86_64-pc-mingw32',)". Reason: プロセスはファイルにアクセスできません。別のプロセスが使用中です。 (13). Retrying... 0:55.14 Traceback (most recent call last): 0:55.14 File "f:/m/mozilla-unified/config/pythonpath.py", line 56, in <module> 0:55.14 main(sys.argv[1:]) 0:55.14 File "f:/m/mozilla-unified/config/pythonpath.py", line 48, in main 0:55.14 execfile(script, frozenglobals) 0:55.14 File "f:/m/mozilla-unified/python/mozbuild/mozbuild/controller/clobber.py", line 196, in <module> 0:55.14 sys.exit(main(sys.argv[1:], os.environ, os.getcwd(), sys.stdout)) 0:55.14 File "f:/m/mozilla-unified/python/mozbuild/mozbuild/controller/clobber.py", line 184, in main 0:55.14 required, performed, message = clobber.maybe_do_clobber(cwd, auto, fh) 0:55.14 File "f:/m/mozilla-unified/python/mozbuild/mozbuild/controller/clobber.py", line 153, in maybe_do_clobber 0:55.14 rmtree(self.topobjdir) 0:55.14 File "f:\m\mozilla-unified\testing\mozbase\mozfile\mozfile\mozfile.py", line 137, in rmtree 0:55.14 return remove(dir) 0:55.14 File "f:\m\mozilla-unified\testing\mozbase\mozfile\mozfile\mozfile.py", line 234, in remove 0:55.14 _call_with_windows_retry(shutil.rmtree, (path,)) 0:55.14 File "f:\m\mozilla-unified\testing\mozbase\mozfile\mozfile\mozfile.py", line 193, in _call_with_windows_retry 0:55.14 _call_windows_retry(*args, **kwargs) 0:55.15 File "f:\m\mozilla-unified\testing\mozbase\mozfile\mozfile\mozfile.py", line 151, in _call_windows_retry 0:55.15 func(*args) 0:55.15 File "c:\mozilla-build\python\lib\shutil.py", line 247, in rmtree 0:55.15 rmtree(fullname, ignore_errors, onerror) 0:55.15 File "c:\mozilla-build\python\lib\shutil.py", line 252, in rmtree 0:55.15 onerror(os.remove, fullname, sys.exc_info()) 0:55.15 File "c:\mozilla-build\python\lib\shutil.py", line 250, in rmtree 0:55.15 os.remove(fullname) 0:55.15 WindowsError: [Error 32] プロセスはファイルにアクセスできません。別のプロセスが使用中です。: 'f:\\m\\mozilla-unified\\obj-x86_64-pc-mingw32\\.mozbuild\\last_log.json' 0:55.15 client.mk:344: recipe for target 'f:/m/mozilla-unified/obj-x86_64-pc-mingw32/CLOBBER' failed 0:55.15 mozmake.EXE: *** [f:/m/mozilla-unified/obj-x86_64-pc-mingw32/CLOBBER] Error 1 0:55.19 235 compiler warnings present. 2
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Please file a new bug.
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Blocks: 1298210
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: