These checks aren't exactly redundant with js::Mutex/PTHREAD_MUTEX_ERRORCHECK, like the other lockHolder members, since there are random assertions that the lock has any holder in various places. These should probably be re-written to pass around LockGuard references, but that would be a lot more churn than I want to do at the moment.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0d41de5799c

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0d562241fab

Comment on attachment 8775708 [details] [diff] [review] Switch the simulators over to js::Thread instead of PRThread Review of attachment 8775708 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jit/arm/Simulator-arm.cpp @@ -1130,5 @@ > > -#ifdef DEBUG > - cacheLockHolder_ = nullptr; > -#endif > - redirection_ = nullptr; D'oh... did not mean to remove the `redirection_ = nullptr;` here...

Sorry for all the churn...

New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1887fac87561

Pushed by nfitzgerald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e834808ca14b Switch the simulators over to js::Thread instead of PRThread; r=terrence

This or something else from the push appears to have turned 10.10 debug cpp tests permared: https://treeherder.mozilla.org/logviewer.html#?job_id=33028238&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/a86df78500c3

Pushed by nfitzgerald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3ec6476e6d89 Switch the simulators over to js::Thread instead of PRThread; r=terrence