Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] Assignee
	Description • 8 years ago

These checks aren't exactly redundant with js::Mutex/PTHREAD_MUTEX_ERRORCHECK,
like the other lockHolder members, since there are random assertions that the
lock has any holder in various places. These should probably be re-written to
pass around LockGuard references, but that would be a lot more churn than I want
to do at the moment.

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] Assignee
	Comment 2 • 8 years ago

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0d41de5799c

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] Assignee
	Comment 4 • 8 years ago

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0d562241fab

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] Assignee
	Comment 5 • 8 years ago

Comment on attachment 8775708 [details] [diff] [review]
Switch the simulators over to js::Thread instead of PRThread

Review of attachment 8775708 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/arm/Simulator-arm.cpp
@@ -1130,5 @@
>  
> -#ifdef DEBUG
> -    cacheLockHolder_ = nullptr;
> -#endif
> -    redirection_ = nullptr;

D'oh... did not mean to remove the `redirection_ = nullptr;` here...

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] Assignee
	Comment 6 • 8 years ago

Sorry for all the churn...

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] Assignee
	Comment 7 • 8 years ago

New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1887fac87561

	Pulsebot
	Comment 8 • 8 years ago

Pushed by nfitzgerald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e834808ca14b
Switch the simulators over to js::Thread instead of PRThread; r=terrence

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 9 • 8 years ago
backout bugherder landing

This or something else from the push appears to have turned 10.10 debug cpp tests permared: https://treeherder.mozilla.org/logviewer.html#?job_id=33028238&repo=mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/a86df78500c3

	Pulsebot
	Comment 10 • 8 years ago

Pushed by nfitzgerald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ec6476e6d89
Switch the simulators over to js::Thread instead of PRThread; r=terrence

	Carsten Book [:Tomcat]
	Comment 11 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/3ec6476e6d89